[IMP] snailmail: correct default_get behavior

1) Use a default_<fname> context key to give a default value and leave 
the management of the default to the orm level when possible.

2) Do not return unwanted default values in default_get override.

2 files changed, 2 insertions, 2 deletions

diff --git a/addons/snailmail/static/src/components/message/message_tests.js b/addons/snailmail/static/src/components/message/message_tests.js
index 01a16040e08..1071c9b24b6 100644
--- a/addons/snailmail/static/src/components/message/message_tests.js
+++ b/addons/snailmail/static/src/components/message/message_tests.js
@@ -622,7 +622,7 @@ QUnit.test('Missing Required Fields', async function (assert) {
             "action should be the one for missing fields"
         );
         assert.strictEqual(
-            payload.options.additional_context.letter_id,
+            payload.options.additional_context.default_letter_id,
             22, // should be the same as the id returned by search
             "action should have correct letter id"
         );
diff --git a/addons/snailmail/static/src/models/message/message.js b/addons/snailmail/static/src/models/message/message.js
index 2ac25fc1ecf..f685e48ac42 100644
--- a/addons/snailmail/static/src/models/message/message.js
+++ b/addons/snailmail/static/src/models/message/message.js
@@ -48,7 +48,7 @@ registerInstancePatchModel('mail.message', 'snailmail/static/src/models/message.
             action: 'snailmail.snailmail_letter_missing_required_fields_action',
             options: {
                 additional_context: {
-                    letter_id: letterIds[0],
+                    default_letter_id: letterIds[0],
                 },
             },
         });