[MOV] mail, sms: move language computation in render mixin directly

PURPOSE

Merge rendering tools used in mail and sms templates as well as partially
in mailings and move them directly in mail.render.mixin.

SPECIFICATIONS

Move tools related to language computation from mail.template model to the
mail.render.mixin. It allows to update both

  * mail.template: simply update calls accordingly;
  * sms.template: remove code doing what is now available through mail.render
    .mixin inherit;

Lang field is moved to mail.render.mixin as it is used notably for the language
computation. It therefore adds the field on mailing.mailing model although
not used currently.

LINKS

Task ID 1963529
Community PR odoo/odoo#32397

4 files changed, 7 insertions, 50 deletions

diff --git a/addons/sms/models/mail_thread.py b/addons/sms/models/mail_thread.py
index 86713fddc24..820c5230cfe 100644
--- a/addons/sms/models/mail_thread.py
+++ b/addons/sms/models/mail_thread.py
@@ -180,8 +180,7 @@ class MailThread(models.AbstractModel):
         if not template and template_xmlid:
             template = self.env.ref(template_xmlid, raise_if_not_found=False)
         if template:
-            template_w_lang = template._get_context_lang_per_id(self.ids)[self.id]
-            body = template._render_template(template_w_lang.body, self._name, self.ids)[self.id]
+            body = template._render_field('body', self.ids, compute_lang=True)[self.id]
         else:
             body = self.env['sms.template']._render_template(template_fallback, self._name, self.ids)[self.id]
         return self._message_sms(body, partner_ids=partner_ids, **kwargs)
diff --git a/addons/sms/models/sms_template.py b/addons/sms/models/sms_template.py
index a2b2300051b..fb5b8877e87 100644
--- a/addons/sms/models/sms_template.py
+++ b/addons/sms/models/sms_template.py
@@ -24,9 +24,6 @@ class SMSTemplate(models.Model):
         help="The type of document this template can be used with", ondelete='cascade')
     model = fields.Char('Related Document Model', related='model_id.model', index=True, store=True, readonly=True)
     body = fields.Char('Body', translate=True, required=True)
-    lang = fields.Char('Language', help="Use this field to either force a specific language (ISO code) or dynamically "
-                                        "detect the language of your recipient by a placeholder expression "
-                                        "(e.g. ${object.partner_id.lang})")
     # Use to create contextual action (same as for email template)
     sidebar_action_id = fields.Many2one('ir.actions.act_window', 'Sidebar action', readonly=True, copy=False,
                                         help="Sidebar action to make this template available on records "
@@ -67,43 +64,3 @@ class SMSTemplate(models.Model):
             if template.sidebar_action_id:
                 template.sidebar_action_id.unlink()
         return True
-
-    # ------------------------------------------------------------
-    # RENDERING
-    # ------------------------------------------------------------
-
-    def _get_context_lang_per_id(self, res_ids):
-        self.ensure_one()
-        if res_ids is None:
-            return {None: self}
-
-        if self.env.context.get('template_preview_lang'):
-            lang = self.env.context.get('template_preview_lang')
-            results = dict((res_id, self.with_context(lang=lang)) for res_id in res_ids)
-        else:
-            rendered_langs = self._render_template(self.lang, self.model, res_ids)
-            results = dict(
-                (res_id, self.with_context(lang=lang) if lang else self)
-                for res_id, lang in rendered_langs.items())
-
-        return results
-
-    def _get_ids_per_lang(self, res_ids):
-        self.ensure_one()
-
-        rids_to_tpl = self._get_context_lang_per_id(res_ids)
-        tpl_to_rids = {}
-        for res_id, template in rids_to_tpl.items():
-            tpl_to_rids.setdefault(template._context.get('lang', self.env.user.lang), []).append(res_id)
-
-        return tpl_to_rids
-
-    def _get_translated_bodies(self, res_ids):
-        """ return sms translated bodies into a dict {'res_id':'body'} """
-        self.ensure_one()
-        lang_to_rids = self._get_ids_per_lang(res_ids)
-        all_bodies = {}
-        for lang, rids in lang_to_rids.items():
-            template = self.with_context(lang=lang)
-            all_bodies.update(template._render_template(template.body, self.model, rids))
-        return all_bodies
diff --git a/addons/sms/wizard/sms_composer.py b/addons/sms/wizard/sms_composer.py
index 60c915d8172..7d5cbc9bfd2 100644
--- a/addons/sms/wizard/sms_composer.py
+++ b/addons/sms/wizard/sms_composer.py
@@ -168,7 +168,7 @@ class SendSMS(models.TransientModel):
     @api.onchange('composition_mode', 'res_model', 'res_id', 'template_id')
     def _onchange_template_id(self):
         if self.template_id and self.composition_mode == 'comment' and self.res_id:
-            self.body = self.template_id._get_translated_bodies([self.res_id])[self.res_id]
+            self.body = self.template_id._render_field('body', [self.res_id], compute_lang=True)[self.res_id]
         elif self.template_id:
             self.body = self.template_id.body
 
@@ -279,7 +279,7 @@ class SendSMS(models.TransientModel):
 
     def _prepare_body_values(self, records):
         if self.template_id and self.body == self.template_id.body:
-            all_bodies = self.template_id._get_translated_bodies(records.ids)
+            all_bodies = self.template_id._render_field('body', records.ids, compute_lang=True)
         else:
             all_bodies = self.env['mail.render.mixin']._render_template(self.body, records._name, records.ids)
         return all_bodies
diff --git a/addons/sms/wizard/sms_template_preview.py b/addons/sms/wizard/sms_template_preview.py
index 9d00185ee2e..837c0b821b8 100644
--- a/addons/sms/wizard/sms_template_preview.py
+++ b/addons/sms/wizard/sms_template_preview.py
@@ -45,6 +45,7 @@ class SMSTemplatePreview(models.TransientModel):
     @api.depends('lang', 'resource_ref')
     def _compute_sms_template_fields(self):
         for wizard in self:
-            # Update body depending of the resource_ref
-            sms_template = wizard.sms_template_id.with_context(lang=wizard.lang)
-            wizard.body = sms_template._render_template(sms_template.body, sms_template.model, wizard.resource_ref.id) if wizard.resource_ref else sms_template.body
+            if wizard.sms_template_id and wizard.resource_ref:
+                wizard.body = wizard.sms_template_id._render_field('body', [wizard.resource_ref.id], set_lang=wizard.lang)[wizard.resource_ref.id]
+            else:
+                wizard.body = wizard.sms_template_id.body