diff options
| author | Romain Derie <rde@odoo.com> | 2020-01-21 14:07:19 +0000 |
|---|---|---|
| committer | Romain Derie <rde@odoo.com> | 2020-01-21 15:32:08 +0000 |
| commit | 98678199a32b3ba9af999f76980a6110546ec0fc (patch) | |
| tree | 3215ff21b65425e0a341b238ce72bfbaf23da103 /addons/sale_quotation_builder | |
| parent | 15c934a1abfc72c965a6b46618b7b2ae6fad49cc (diff) | |
[FIX] *: fix translations inconsistency in 't-set'
This commit fix most `t-set` errors that either led to:
1. unwanted text to be considered as translatable.
eg: `<t t-set="classes">text-left bg-100 p4</t>` would create an
`ir.translation`.
2. text that should be translatable were not.
eg: `<t t-set="text" t-value="'Both'"/>` would not create an
`ir.translation` while it should.
If a text should be translatable, it should never be inside a `t-value`:
- `<t t-set="text">Both</t>`
If a text should not be translatable, it sould either be inside `t-value`,
`t-valuef` or the `<t>` tag should have `t-translation="off"`:
- `<t t-set="classes" t-translation="off">text-left bg-100 p4</t>`
- `<t t-set="classes" t-valuef="text-left bg-100 p4"/>`
- `<t t-set="classes" t-value="'text-left bg-100 p4'"/>`
https://github.com/odoo/odoo/pull/43660
https://github.com/odoo/enterprise/pull/7839
https://github.com/odoo/design-themes/pull/203
closes odoo/odoo#43660
Related: odoo/enterprise#7839
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Diffstat (limited to 'addons/sale_quotation_builder')
| -rw-r--r-- | addons/sale_quotation_builder/views/sale_portal_templates.xml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/addons/sale_quotation_builder/views/sale_portal_templates.xml b/addons/sale_quotation_builder/views/sale_portal_templates.xml index fe8b0056d10..97687814af5 100644 --- a/addons/sale_quotation_builder/views/sale_portal_templates.xml +++ b/addons/sale_quotation_builder/views/sale_portal_templates.xml @@ -88,7 +88,7 @@ <t t-set="_message"> An awesome <a target="_blank" href="https://www.odoo.com/page/crm?utm_source=db&utm_medium=portal">Open Source CRM</a> </t> - <t t-set="_utm_medium">portal</t> + <t t-set="_utm_medium" t-valuef="portal"/> </t> </xpath> </template> |