diff options
| author | Martin Trigaux <mat@odoo.com> | 2020-02-14 11:22:15 +0100 |
|---|---|---|
| committer | Martin Trigaux <mat@odoo.com> | 2020-05-14 13:59:10 +0200 |
| commit | d9287caf9408bb4ff85ad734cbca08e44321e205 (patch) | |
| tree | 0d3b7c5705e5172176a7d76bf9098e381190bf4b /addons/sale_management | |
| parent | 56a8c9e4311d24c33b7ad08b8230e4be345a85b8 (diff) | |
[IMP] *: convert to private methods
render, render_template, load, activity_schedule_with_view,
get_website_pages should all be private:
It should not be possible to render an aribtrary template only with
its name or id
Still need to render some qweb views from js so the method
render_template is kept public.
This explains why the website editor still need read access on
ir.ui.view as we want to allow any snippet to be rendered.
Diffstat (limited to 'addons/sale_management')
| -rw-r--r-- | addons/sale_management/controllers/portal.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/addons/sale_management/controllers/portal.py b/addons/sale_management/controllers/portal.py index a2690237709..da3c3bbcc23 100644 --- a/addons/sale_management/controllers/portal.py +++ b/addons/sale_management/controllers/portal.py @@ -28,7 +28,7 @@ class CustomerPortal(CustomerPortal): 'order_line_price_subtotal': format_price(order_line.price_subtotal) }) try: - results['order_totals_table'] = request.env['ir.ui.view'].render_template('sale.sale_order_portal_content_totals_table', {'sale_order': order_sudo}) + results['order_totals_table'] = request.env['ir.ui.view']._render_template('sale.sale_order_portal_content_totals_table', {'sale_order': order_sudo}) except ValueError: pass @@ -58,7 +58,7 @@ class CustomerPortal(CustomerPortal): results = self._get_portal_order_details(order_sudo) results.update({ 'unlink': True, - 'sale_template': request.env['ir.ui.view'].render_template('sale.sale_order_portal_content', { + 'sale_template': request.env['ir.ui.view']._render_template('sale.sale_order_portal_content', { 'sale_order': order_sudo, 'report_type': "html" }), @@ -84,7 +84,7 @@ class CustomerPortal(CustomerPortal): option_sudo.add_option_to_order() results = self._get_portal_order_details(order_sudo) - results['sale_template'] = request.env['ir.ui.view'].render_template("sale.sale_order_portal_content", { + results['sale_template'] = request.env['ir.ui.view']._render_template("sale.sale_order_portal_content", { 'sale_order': option_sudo.order_id, 'report_type': "html" }) |