diff options
| author | wan <wan@odoo.com> | 2021-04-02 10:33:24 +0000 |
|---|---|---|
| committer | wan <wan@odoo.com> | 2021-04-12 18:19:00 +0000 |
| commit | fcaa54939e9a4f0dd5e47cd0ccffe7aa24bd451c (patch) | |
| tree | 04953cd19b1bcb09648fc88624c3da7e403fc706 /addons/purchase_stock | |
| parent | 14abcfa92cd37db82338f9a933221142026a78bd (diff) | |
[FIX] account: never set default for invoice_date
For customer invoices:
* do not set default date because if you prepare an invoice (and it gets
a default date), then validate it the next day, the date will be wrong
* set the date when posting if it wasn't set, because why not?
For vendor bills:
* do not set default date because you rarely encode a bill at the bill
date. Forcing the user to enter it reduces risks of user error
(duplicated vendor bill)
* do not set it when posting, same reason.
opw-2492862
Related #68368
Closes #68367
closes odoo/odoo#68689
Related: odoo/enterprise#17502
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Diffstat (limited to 'addons/purchase_stock')
| -rw-r--r-- | addons/purchase_stock/tests/test_purchase_order.py | 2 | ||||
| -rw-r--r-- | addons/purchase_stock/tests/test_stockvaluation.py | 7 |
2 files changed, 9 insertions, 0 deletions
diff --git a/addons/purchase_stock/tests/test_purchase_order.py b/addons/purchase_stock/tests/test_purchase_order.py index ddb5dd80ceb..7d98d24792e 100644 --- a/addons/purchase_stock/tests/test_purchase_order.py +++ b/addons/purchase_stock/tests/test_purchase_order.py @@ -106,6 +106,7 @@ class TestPurchaseOrder(ValuationReconciliationTestCommon): #After Receiving all products create vendor bill. move_form = Form(self.env['account.move'].with_context(default_move_type='in_invoice')) + move_form.invoice_date = move_form.date move_form.partner_id = self.partner_a move_form.purchase_id = self.po self.invoice = move_form.save() @@ -136,6 +137,7 @@ class TestPurchaseOrder(ValuationReconciliationTestCommon): self.assertEqual(self.po.order_line[0].qty_received, 3.0, 'Purchase: delivered quantity should be 3.0 instead of "%s" after picking return' % self.po.order_line[0].qty_received) #Create vendor bill for refund qty move_form = Form(self.env['account.move'].with_context(default_move_type='in_refund')) + move_form.invoice_date = move_form.date move_form.partner_id = self.partner_a move_form.purchase_id = self.po self.invoice = move_form.save() diff --git a/addons/purchase_stock/tests/test_stockvaluation.py b/addons/purchase_stock/tests/test_stockvaluation.py index e2972a456a4..06cfabd666a 100644 --- a/addons/purchase_stock/tests/test_stockvaluation.py +++ b/addons/purchase_stock/tests/test_stockvaluation.py @@ -379,6 +379,7 @@ class TestStockValuationWithCOA(AccountTestInvoicingCommon): receipt_po1.button_validate() move_form = Form(self.env['account.move'].with_context(default_move_type='in_invoice')) + move_form.invoice_date = move_form.date move_form.partner_id = self.partner_id move_form.purchase_id = po1 invoice_po1 = move_form.save() @@ -404,6 +405,7 @@ class TestStockValuationWithCOA(AccountTestInvoicingCommon): receipt_po2.button_validate() move_form = Form(self.env['account.move'].with_context(default_move_type='in_invoice')) + move_form.invoice_date = move_form.date move_form.partner_id = self.partner_id move_form.purchase_id = po2 invoice_po2 = move_form.save() @@ -428,6 +430,7 @@ class TestStockValuationWithCOA(AccountTestInvoicingCommon): # create a credit note for po2 move_form = Form(self.env['account.move'].with_context(default_move_type='in_refund')) + move_form.invoice_date = move_form.date move_form.partner_id = self.partner_id move_form.purchase_id = po2 with move_form.invoice_line_ids.edit(0) as line_form: @@ -462,6 +465,7 @@ class TestStockValuationWithCOA(AccountTestInvoicingCommon): # Create an invoice with a different price move_form = Form(self.env['account.move'].with_context(default_move_type='in_invoice')) + move_form.invoice_date = move_form.date move_form.partner_id = order.partner_id move_form.purchase_id = order with move_form.invoice_line_ids.edit(0) as line_form: @@ -1211,6 +1215,7 @@ class TestStockValuationWithCOA(AccountTestInvoicingCommon): # Create an invoice with a different price and a discount invoice_form = Form(self.env['account.move'].with_context(default_move_type='in_invoice')) + invoice_form.invoice_date = invoice_form.date invoice_form.purchase_id = order with invoice_form.invoice_line_ids.edit(0) as line_form: line_form.price_unit = 100.0 @@ -1257,6 +1262,7 @@ class TestStockValuationWithCOA(AccountTestInvoicingCommon): # Create an invoice with a different price and a discount invoice_form = Form(self.env['account.move'].with_context(default_move_type='in_invoice')) + invoice_form.invoice_date = invoice_form.date invoice_form.purchase_id = order with invoice_form.invoice_line_ids.edit(0) as line_form: line_form.tax_ids.clear() @@ -1303,6 +1309,7 @@ class TestStockValuationWithCOA(AccountTestInvoicingCommon): # Create an invoice with a different price and a discount invoice_form = Form(self.env['account.move'].with_context(default_move_type='in_invoice')) + invoice_form.invoice_date = invoice_form.date invoice_form.purchase_id = order with invoice_form.invoice_line_ids.edit(0) as line_form: line_form.price_unit = 100.0 |