[FIX] all: remove external ids fakely from base

Several modules defines records with the external ID `base.foo_bar` while it is
created inside this module (typically menus and groups).
While there is no technical reasons to do so but this may introduce issues:

- these records will not be deleted during uninstall
- if a language is loaded before the installation of the module, it won't be
  translated

The uninstallation will only remove the records with an external id linked to
this module (these would only be removed when removing base).

Installing a language before the module will drop the translations not linked
to an existing external id (as it can not be resolved).

This commit correct all the external ids tagged as from base or other incorrect
modules.

5 files changed, 11 insertions, 11 deletions

diff --git a/addons/project/data/web_planner_data.xml b/addons/project/data/web_planner_data.xml
index 10716495060..ce1b1be2077 100644
--- a/addons/project/data/web_planner_data.xml
+++ b/addons/project/data/web_planner_data.xml
@@ -1076,7 +1076,7 @@
     <record id="planner_project" model="web.planner">
         <field name="name">Project Management planner</field>
         <field name="view_id" ref="project_planner"/>
-        <field name="menu_id" ref="base.menu_main_pm"/>
+        <field name="menu_id" ref="menu_main_pm"/>
         <field name="progress">7</field>
         <field name="planner_application">planner_project</field>
         <field name="tooltip_planner"><![CDATA[
diff --git a/addons/project/static/src/js/tour.js b/addons/project/static/src/js/tour.js
index 4f9813c61d0..a455f927834 100644
--- a/addons/project/static/src/js/tour.js
+++ b/addons/project/static/src/js/tour.js
@@ -9,7 +9,7 @@ var _t = core._t;
 tour.register('project_tour', {
     url: "/web",
 }, [tour.STEPS.MENU_MORE, {
-    trigger: '.o_app[data-menu-xmlid="base.menu_main_pm"], .oe_menu_toggler[data-menu-xmlid="base.menu_main_pm"]',
+    trigger: '.o_app[data-menu-xmlid="project.menu_main_pm"], .oe_menu_toggler[data-menu-xmlid="project.menu_main_pm"]',
     content: _t('Want a better way to <b>manage your projects</b>? <i>It starts here.</i>'),
     position: 'bottom',
 }, {
diff --git a/addons/project/views/project_views.xml b/addons/project/views/project_views.xml
index dc8013c4e15..0ed16dcaf4b 100644
--- a/addons/project/views/project_views.xml
+++ b/addons/project/views/project_views.xml
@@ -3,17 +3,17 @@
 
         <!-- Top menu item -->
         <menuitem name="Project"
-            id="base.menu_main_pm"
+            id="menu_main_pm"
             groups="group_project_manager,group_project_user"
             web_icon="project,static/description/icon.png"
             sequence="50"/>
 
         <menuitem name="Search"
             id="menu_project_management"
-            parent="base.menu_main_pm"
+            parent="menu_main_pm"
             sequence="2" groups="base.group_no_one,group_project_user"/>
 
-        <menuitem id="menu_project_config" name="Configuration" parent="base.menu_main_pm"
+        <menuitem id="menu_project_config" name="Configuration" parent="menu_main_pm"
             sequence="100" groups="project.group_project_manager"/>
 
         <record id="view_task_search_form" model="ir.ui.view">
@@ -680,9 +680,9 @@ action = model.activate_sample_project()
 
         <menuitem id="menu_tasks_config" name="GTD" parent="menu_project_config" sequence="2"/>
 
-        <menuitem action="open_task_type_form" id="base.menu_project_config_project" name="Stages" parent="menu_project_config" sequence="3" groups="group_project_manager"/>
+        <menuitem action="open_task_type_form" id="menu_project_config_project" name="Stages" parent="menu_project_config" sequence="3" groups="group_project_manager"/>
 
-        <menuitem action="open_view_project_all" id="menu_projects" name="Dashboard" parent="base.menu_main_pm" sequence="1"/>
+        <menuitem action="open_view_project_all" id="menu_projects" name="Dashboard" parent="menu_main_pm" sequence="1"/>
         <menuitem action="open_view_project_all_config" id="menu_projects_config" name="Projects" parent="menu_project_config" sequence="10"/>
 
         <!-- User Form -->
@@ -724,9 +724,9 @@ action = model.activate_sample_project()
         <menuitem action="project_tags_action" id="menu_project_tags_act" parent="menu_project_config" groups="base.group_no_one"/>
 
         <!-- Reporting menus -->
-        <menuitem id="base.menu_project_report" name="Reports"
+        <menuitem id="menu_project_report" name="Reports"
             groups="project.group_project_manager"
             action="project.action_project_task_user_tree"
-            parent="base.menu_main_pm" sequence="99"/>
+            parent="menu_main_pm" sequence="99"/>
 
 </odoo>
diff --git a/addons/project/views/res_config_views.xml b/addons/project/views/res_config_views.xml
index 3a7abe453e1..265a08ce932 100644
--- a/addons/project/views/res_config_views.xml
+++ b/addons/project/views/res_config_views.xml
@@ -43,6 +43,6 @@
             <field name="target">inline</field>
         </record>
 
-        <menuitem id="base.menu_project_general_settings" name="Settings" parent="menu_project_config"
+        <menuitem id="menu_project_general_settings" name="Settings" parent="menu_project_config"
             sequence="0" action="action_config_settings" groups="base.group_system"/>
 </odoo>
diff --git a/addons/project/views/tour_views.xml b/addons/project/views/tour_views.xml
index 541c4e0f251..3a572ab85cc 100644
--- a/addons/project/views/tour_views.xml
+++ b/addons/project/views/tour_views.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <odoo>
     <!-- Make the xmlid of menus required by the Project tour available in webclient -->
-    <record id="base.menu_main_pm" model="ir.ui.menu">
+    <record id="menu_main_pm" model="ir.ui.menu">
         <field name="load_xmlid" eval="True"/>
     </record>
     <record id="menu_projects" model="ir.ui.menu">