[REM] project: remove state field on project.project

Also remove unused method _generate_task()

2 files changed, 15 insertions, 35 deletions

diff --git a/addons/project/tests/test_access_rights.py b/addons/project/tests/test_access_rights.py
index 61e50c4494f..b0979927812 100644
--- a/addons/project/tests/test_access_rights.py
+++ b/addons/project/tests/test_access_rights.py
@@ -38,14 +38,14 @@ class TestPortalProject(TestPortalProjectBase):
         pigs.write({'privacy_visibility': 'portal'})
 
         # Do: Alfred reads project -> ok (employee ok public)
-        pigs.sudo(self.user_projectuser).read(['state'])
+        pigs.sudo(self.user_projectuser).read(['user_id'])
         # Test: all project tasks visible
         tasks = self.env['project.task'].sudo(self.user_projectuser).search([('project_id', '=', pigs.id)])
         self.assertEqual(tasks, self.task_1 | self.task_2 | self.task_3 | self.task_4 | self.task_5 | self.task_6,
                          'access rights: project user should see all tasks of a portal project')
 
         # Do: Bert reads project -> crash, no group
-        self.assertRaises(AccessError, pigs.sudo(self.user_noone).read, ['state'])
+        self.assertRaises(AccessError, pigs.sudo(self.user_noone).read, ['user_id'])
         # Test: no project task searchable
         self.assertRaises(AccessError, self.env['project.task'].sudo(self.user_noone).search, [('project_id', '=', pigs.id)])
 
@@ -54,11 +54,11 @@ class TestPortalProject(TestPortalProjectBase):
         self.task_1.sudo(self.user_projectuser).message_subscribe_users(user_ids=[self.user_portal.id])
         self.task_3.sudo(self.user_projectuser).message_subscribe_users(user_ids=[self.user_portal.id])
         # Do: Chell reads project -> ok (portal ok public)
-        pigs.sudo(self.user_portal).read(['state'])
+        pigs.sudo(self.user_portal).read(['user_id'])
         # Do: Donovan reads project -> ko (public ko portal)
         # TODO: Change the except_orm to Warning ( Because here it's call check_access_rule
         # which still generate exception in except_orm.)
-        self.assertRaises(except_orm, pigs.sudo(self.user_public).read, ['state'])
+        self.assertRaises(except_orm, pigs.sudo(self.user_public).read, ['user_id'])
         # Test: no access right to project.task
         self.assertRaises(AccessError, self.env['project.task'].sudo(self.user_public).search, [])
         # Data: task follower cleaning
@@ -71,23 +71,23 @@ class TestPortalProject(TestPortalProjectBase):
 
         pigs.write({'privacy_visibility': 'employees'})
         # Do: Alfred reads project -> ok (employee ok employee)
-        pigs.sudo(self.user_projectuser).read(['state'])
+        pigs.sudo(self.user_projectuser).read(['user_id'])
         # Test: all project tasks visible
         tasks = self.env['project.task'].sudo(self.user_projectuser).search([('project_id', '=', pigs.id)])
         test_task_ids = set([self.task_1.id, self.task_2.id, self.task_3.id, self.task_4.id, self.task_5.id, self.task_6.id])
         self.assertEqual(set(tasks.ids), test_task_ids,
                         'access rights: project user cannot see all tasks of an employees project')
         # Do: Bert reads project -> crash, no group
-        self.assertRaises(AccessError, pigs.sudo(self.user_noone).read, ['state'])
+        self.assertRaises(AccessError, pigs.sudo(self.user_noone).read, ['user_id'])
         # Do: Chell reads project -> ko (portal ko employee)
         # TODO Change the except_orm to Warning
-        self.assertRaises(except_orm, pigs.sudo(self.user_portal).read, ['state'])
+        self.assertRaises(except_orm, pigs.sudo(self.user_portal).read, ['user_id'])
         # Test: no project task visible + assigned
         tasks = self.env['project.task'].sudo(self.user_portal).search([('project_id', '=', pigs.id)])
         self.assertFalse(tasks.ids, 'access rights: portal user should not see tasks of an employees project, even if assigned')
         # Do: Donovan reads project -> ko (public ko employee)
         # TODO Change the except_orm to Warning
-        self.assertRaises(except_orm, pigs.sudo(self.user_public).read, ['state'])
+        self.assertRaises(except_orm, pigs.sudo(self.user_public).read, ['user_id'])
         # Do: project user is employee and can create a task
         tmp_task = self.env['project.task'].sudo(self.user_projectuser).with_context({'mail_create_nolog': True}).create({
             'name': 'Pigs task',
@@ -101,17 +101,17 @@ class TestPortalProject(TestPortalProjectBase):
 
         # Do: Alfred reads project -> ko (employee ko followers)
         # TODO Change the except_orm to Warning
-        self.assertRaises(AccessError, pigs.sudo(self.user_projectuser).read, ['state'])
+        self.assertRaises(AccessError, pigs.sudo(self.user_projectuser).read, ['user_id'])
         # Test: no project task visible
         tasks = self.env['project.task'].sudo(self.user_projectuser).search([('project_id', '=', pigs.id)])
         self.assertEqual(tasks, self.task_1,
                          'access rights: employee user should not see tasks of a not-followed followers project, only assigned')
 
         # Do: Bert reads project -> crash, no group
-        self.assertRaises(AccessError, pigs.sudo(self.user_noone).read, ['state'])
+        self.assertRaises(AccessError, pigs.sudo(self.user_noone).read, ['user_id'])
 
         # Do: Chell reads project -> ko (portal ko employee)
-        self.assertRaises(except_orm, pigs.sudo(self.user_portal).read, ['state'])
+        self.assertRaises(except_orm, pigs.sudo(self.user_portal).read, ['user_id'])
         # Test: no project task visible
         tasks = self.env['project.task'].sudo(self.user_portal).search([('project_id', '=', pigs.id)])
         self.assertEqual(tasks, self.task_3,
@@ -119,7 +119,7 @@ class TestPortalProject(TestPortalProjectBase):
 
         # Do: Donovan reads project -> ko (public ko employee)
         # TODO Change the except_orm to Warning
-        self.assertRaises(except_orm, pigs.sudo(self.user_public).read, ['state'])
+        self.assertRaises(except_orm, pigs.sudo(self.user_public).read, ['user_id'])
 
         # Data: subscribe Alfred, Chell and Donovan as follower
         pigs.message_subscribe_users(user_ids=[self.user_projectuser.id, self.user_portal.id, self.user_public.id])
@@ -129,12 +129,12 @@ class TestPortalProject(TestPortalProjectBase):
         # Do: Alfred reads project -> ok (follower ok followers)
         prout = pigs.sudo(self.user_projectuser)
         prout.invalidate_cache()
-        prout.read(['state'])
+        prout.read(['user_id'])
         # Do: Chell reads project -> ok (follower ok follower)
-        pigs.sudo(self.user_portal).read(['state'])
+        pigs.sudo(self.user_portal).read(['user_id'])
         # Do: Donovan reads project -> ko (public ko follower even if follower)
         # TODO Change the except_orm to Warning
-        self.assertRaises(except_orm, pigs.sudo(self.user_public).read, ['state'])
+        self.assertRaises(except_orm, pigs.sudo(self.user_public).read, ['user_id'])
         # Do: project user is follower of the project and can create a task
         self.env['project.task'].sudo(self.user_projectuser.id).with_context({'mail_create_nolog': True}).create({
             'name': 'Pigs task', 'project_id': pigs.id
diff --git a/addons/project/tests/test_project_flow.py b/addons/project/tests/test_project_flow.py
index aabc35d0421..36b5c41c9b7 100644
--- a/addons/project/tests/test_project_flow.py
+++ b/addons/project/tests/test_project_flow.py
@@ -37,28 +37,8 @@ class TestProjectFlow(TestProjectBase):
     def test_project_process_project_manager_duplicate(self):
         pigs = self.project_pigs.sudo(self.user_projectmanager)
         dogs = pigs.copy()
-        self.assertEqual(dogs.state, 'open')
         self.assertEqual(len(dogs.tasks), 2, 'project: duplicating a project must duplicate its tasks')
 
-    def test_project_process_project_manager_state(self):
-        pigs = self.project_pigs.sudo(self.user_projectmanager)
-        pigs.state = 'pending'
-        self.assertEqual(pigs.state, 'pending')
-        # Re-open
-        pigs.state = 'open'
-        self.assertEqual(pigs.state, 'open')
-        # Close project
-        pigs.state = 'close'
-        self.assertEqual(pigs.state, 'close')
-        # Re-open
-        pigs.state = 'open'
-        # Copy the project
-        dogs = pigs.copy()
-        self.assertEqual(len(dogs.tasks), 2, 'project: copied project should have copied task')
-        # Cancel the project
-        pigs.state = 'cancelled'
-        self.assertEqual(pigs.state, 'cancelled', 'project: cancelled project should be in cancel state')
-
     @mute_logger('openerp.addons.mail.mail_thread')
     def test_task_process_without_stage(self):
         # Do: incoming mail from an unknown partner on an alias creates a new task 'Frogs'