diff options
| author | Rémi Rahir <rar@odoo.com> | 2018-02-06 10:08:35 +0100 |
|---|---|---|
| committer | Rémi Rahir <rar@odoo.com> | 2018-02-07 14:22:46 +0100 |
| commit | 376415052c67ad2e63baa06410c964077e2deee4 (patch) | |
| tree | bafc2bd4c1e72995101418fbb54fd76ba8987772 /addons/phone_validation/tools/phone_validation.py | |
| parent | 2c6bad6b75c9c9f66abc4bdbecace74536556adc (diff) | |
[FIX] phone_validation, crm_phone_validation: Phone number parsing
Before this commit, when filing a phone number field on a model form (typically on website_form),
the module phonenumbers would try to parse the number against the country of the model.
However, this call fails when the number starts with 00 instead of + and that the model
doesn't have a country_id field or if said field is not set.
For this specific case, we chose to skip the number parsing altogether as providing a default
country to the parser can lead to a wrong parsing. i.e, phonenumbers.parse(+32477111111, 'US') will
find the number as US-based when it is a belgian number.
solves issue #22513
Also corrected a faulty behaviour where the option to have a number parsed in its international format
field `phone_international_format` on `res.company` was never properly assessed when the field comany_id of a
model was not present in the model's form view. Added company_id field on opportunity's form view for a proper fix.
Also fixed a syntax error in a logger.
Diffstat (limited to 'addons/phone_validation/tools/phone_validation.py')
| -rw-r--r-- | addons/phone_validation/tools/phone_validation.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/addons/phone_validation/tools/phone_validation.py b/addons/phone_validation/tools/phone_validation.py index 940c4300f26..7ca7bed6ea8 100644 --- a/addons/phone_validation/tools/phone_validation.py +++ b/addons/phone_validation/tools/phone_validation.py @@ -41,7 +41,7 @@ try: if raise_exception: raise else: - _logger.warning(_('Unable to format %s:\n%s') % number, e) + _logger.warning(_('Unable to format %s:\n%s'), number, e) return number if always_international or phone_nbr.country_code != country_phone_code: phone_fmt = phonenumbers.PhoneNumberFormat.INTERNATIONAL |
