diff options
| author | Atul Patel <atp@openerp.com> | 2017-06-14 12:08:13 +0530 |
|---|---|---|
| committer | Yannick Tivisse <yti@odoo.com> | 2017-07-17 13:18:37 +0200 |
| commit | 9f649f3e403227eddde020df6e92c6baea0cdd12 (patch) | |
| tree | c93a3e014c04cd54f53166eeea89eee41c3778b8 /addons/pad | |
| parent | 2c9ea8700a579fd49c2ae39a18891186ff57f404 (diff) | |
[FIX] pad: Use a `post` instead of a `get` on the request
The old code used Request(data=)]( https://github.com/odoo-dev/odoo/blob/723b083cf5e51beec166059350466e5504db46c9/addons/pad/py_etherpad/__init__.py#L39)
Which however means it did a POST:
> the HTTP request will be a POST instead of a GET when the data parameter is provided
yet the code currently uses `requests.get`, so [it looks very much like a mistake when converting from urllib to requests](https://github.com/odoo-dev/odoo/commit/01e35141479b8dfc4a390518f89fc52e7cec5396#diff-3303eb022ac36e1ef7258c28f24f6de6).
Diffstat (limited to 'addons/pad')
| -rw-r--r-- | addons/pad/py_etherpad/__init__.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/addons/pad/py_etherpad/__init__.py b/addons/pad/py_etherpad/__init__.py index d1040cec852..fc9721eb9c8 100644 --- a/addons/pad/py_etherpad/__init__.py +++ b/addons/pad/py_etherpad/__init__.py @@ -30,7 +30,7 @@ class EtherpadLiteClient: params = arguments or {} params['apikey'] = self.apiKey - r = requests.get(url, data=params, timeout=self.TIMEOUT) + r = requests.post(url, data=params, timeout=self.TIMEOUT) r.raise_for_status() return self.handleResult(r.json()) |