diff options
| author | Nasreddin (bon) <bon@odoo.com> | 2020-06-04 09:33:27 +0000 |
|---|---|---|
| committer | Nasreddin (bon) <bon@odoo.com> | 2020-06-04 15:41:02 +0000 |
| commit | 896b5bb8268abac94adfe4aad55e13e69337b478 (patch) | |
| tree | 98f0313e6da012549fc0936bde8e7e9dc607e4b3 /addons/mass_mailing_sms/views | |
| parent | 842497e8b82db006b6a61013495e4b799124555b (diff) | |
[FIX] mass_mailing_sms: Handle same sms_code in multiple traces
Issue
- Go to unsubsribe sms page where the 'sms_code' is the same
in multiple traces
- Fill the correct phone number (same one of any traces)
- Click on 'Unsubscribe me'
Traceback is raised.
Also, if empty phone number, still have successfull message.
Cause
Multiple traces with same "sms_code" but different "sms_number".
The current behavior does not handle multiple traces.
Solution
- Filter and retrieve the trace with the correct "sms_number".
- Add 'required' attribute on phone number input.
opw-2264200
closes odoo/odoo#52452
X-original-commit: 34a8f63332e8269c2dbf5fa2b3ca16913798532c
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Signed-off-by: bon-odoo <nboulif@users.noreply.github.com>
Diffstat (limited to 'addons/mass_mailing_sms/views')
| -rw-r--r-- | addons/mass_mailing_sms/views/mass_mailing_sms_templates_portal.xml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/addons/mass_mailing_sms/views/mass_mailing_sms_templates_portal.xml b/addons/mass_mailing_sms/views/mass_mailing_sms_templates_portal.xml index bd1f927eb9d..bf5a7683dc0 100644 --- a/addons/mass_mailing_sms/views/mass_mailing_sms_templates_portal.xml +++ b/addons/mass_mailing_sms/views/mass_mailing_sms_templates_portal.xml @@ -12,7 +12,7 @@ <div class="form-group row"> <label for="sms_number" class="col-sm-2 col-form-label">Number</label> <div class="col-sm-10"> - <input type="text" class="form-control" name="sms_number" id="sms_number"/> + <input type="text" class="form-control" name="sms_number" id="sms_number" t-att-required="true"/> </div> </div> <input type="hidden" name="csrf_token" t-att-value="request.csrf_token()"/> |