diff options
| author | Victor Feyens <vfe@odoo.com> | 2020-08-10 13:17:00 +0000 |
|---|---|---|
| committer | Victor Feyens <vfe@odoo.com> | 2020-08-14 09:56:10 +0000 |
| commit | fdb23e282b90ad95e4f909f7232eb0aa36038836 (patch) | |
| tree | c29267645405b1fabd0b12c1276b89e6c7058f58 /addons/mail_bot | |
| parent | 65bf6988f941be6fe1e88202bc814e4b645abf79 (diff) | |
[IMP] *: wrong any() usage
Replace wrong usages of any(list|recordset), by any(generator)
to speed up computations, avoiding list creations and/or looping twice on a recordset
for nothing.
any([generator]) => any(generator)
any(filtered) => any(generator)
closes odoo/odoo#55768
Related: odoo/enterprise#12360
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Diffstat (limited to 'addons/mail_bot')
| -rw-r--r-- | addons/mail_bot/models/res_partner.py | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/addons/mail_bot/models/res_partner.py b/addons/mail_bot/models/res_partner.py index 2a6ec5eca55..8a3fc3ca106 100644 --- a/addons/mail_bot/models/res_partner.py +++ b/addons/mail_bot/models/res_partner.py @@ -20,8 +20,7 @@ class Partner(models.Model): [users, partners] = super(Partner, self).get_mention_suggestions(search, limit=limit) if len(partners) + len(users) < limit and "odoobot".startswith(search.lower()): odoobot = self.env.ref("base.partner_root") - if not any([elem['id'] == odoobot.id for elem in partners]): - if odoobot: - partners.append({'id': odoobot.id, 'name': odoobot.name, 'email': odoobot.email}) + if odoobot and not any(elem['id'] == odoobot.id for elem in partners): + partners.append({'id': odoobot.id, 'name': odoobot.name, 'email': odoobot.email}) return [users, partners] |