[REF] mail, various: apply light code cleaning

Purpose of this commit is to clean some bits of code, notably calls to
message_post/log as well as notification methods. It will ease performance
improvement work.

Small optimization: account: read content after extension check

Parameter cleaning

 * use message log with kwargs instead of args;
 * remove message post after hook useless parameters;
 * remove _notify_email_recipients useless message parameter;
 * remove message_notify useless send_after_commit parameters;
 * remove message post params matching default values;

Other improvements

 * remove message_post commands support for partners and channels;
 * only calls message_post with ids list for channels and partners. We
   don't support mix of ids and command anymore to simplify code;
 * remove support of private discussion in mail.thread adding partners
   as recipients, as there is no use anymore;

Related to task 1943901
Linked to PR #32404

1 files changed, 3 insertions, 3 deletions

diff --git a/addons/mail_bot/models/mail_thread.py b/addons/mail_bot/models/mail_thread.py
index 81e9fa44711..9a5e2e05a99 100644
--- a/addons/mail_bot/models/mail_thread.py
+++ b/addons/mail_bot/models/mail_thread.py
@@ -7,6 +7,6 @@ from odoo import models
 class MailThread(models.AbstractModel):
     _inherit = 'mail.thread'
 
-    def _message_post_after_hook(self, message, values, model_description=False, mail_auto_delete=True):
-        self.env['mail.bot']._apply_logic(self, values)
-        return super(MailThread, self)._message_post_after_hook(message, values, model_description=model_description, mail_auto_delete=mail_auto_delete)
+    def _message_post_after_hook(self, message, msg_vals, model_description, mail_auto_delete):
+        self.env['mail.bot']._apply_logic(self, msg_vals)
+        return super(MailThread, self)._message_post_after_hook(message, msg_vals, model_description, mail_auto_delete)