[FIX][REF] mail: several thread windows fixes

This commit fixes some bugs on thread windows, and make some
improvements on tests related to thread windows.

Fixes:

	1. Correctly position last visible thread window when there are more
	   open thread windows than available slots.
	2. Closing a thread window now marks it as read.
	3. Can now fold/unfold the blank thread window (aka 'New' thread window).

Tests cleaning:

	1. Removed unnecessary 'before assertions' in thread window tests.
	   > Solved with this: https://github.com/odoo/odoo/commit/9b1daa1218f7adf9d741afba607ef5b55b16e3e6
	1. Added basic rendering test for a (non-blank) thread window.
	2. Cleaned thread window tests
	   > Split in different files.
	   > Grouped in 'Thread Window' QUnit module.

1 files changed, 253 insertions, 0 deletions

diff --git a/addons/mail/static/tests/thread_window/basic_thread_window_tests.js b/addons/mail/static/tests/thread_window/basic_thread_window_tests.js
new file mode 100644
index 00000000000..ffda7d95700
--- /dev/null
+++ b/addons/mail/static/tests/thread_window/basic_thread_window_tests.js
@@ -0,0 +1,253 @@
+odoo.define('mail.basicThreadWindowTests', function (require) {
+"use strict";
+
+var mailTestUtils = require('mail.testUtils');
+
+var framework = require('web.framework');
+var testUtils = require('web.test_utils');
+var Widget = require('web.Widget');
+
+QUnit.module('mail', {}, function () {
+QUnit.module('Thread Window', {}, function () {
+QUnit.module('Basic', {
+    beforeEach: function () {
+        var self = this;
+
+        // define channel to link to chat window
+        this.data = {
+            'mail.message': {
+                fields: {},
+                records: [],
+            },
+            initMessaging: {
+                channel_slots: {
+                    channel_channel: [{
+                        id: 1,
+                        channel_type: "channel",
+                        name: "general",
+                    }],
+                },
+            },
+        };
+        this.services = mailTestUtils.getMailServices();
+        this.ORIGINAL_THREAD_WINDOW_APPENDTO = this.services.mail_service.prototype.THREAD_WINDOW_APPENDTO;
+
+        this.createParent = function (params) {
+            var widget = new Widget();
+
+            // in non-debug mode, append thread windows in qunit-fixture
+            // note that it does not hide thread window because it uses fixed
+            // position, and qunit-fixture uses absolute...
+            if (params.debug) {
+                self.services.mail_service.prototype.THREAD_WINDOW_APPENDTO = 'body';
+            } else {
+                self.services.mail_service.prototype.THREAD_WINDOW_APPENDTO = '#qunit-fixture';
+            }
+
+            testUtils.addMockEnvironment(widget, params);
+            return widget;
+        };
+    },
+    afterEach: function () {
+        // reset thread window append to body
+        this.services.mail_service.prototype.THREAD_WINDOW_APPENDTO = 'body';
+    },
+});
+
+QUnit.test('basic rendering thread window', function (assert) {
+    assert.expect(10);
+
+    var parent = this.createParent({
+        data: this.data,
+        services: this.services,
+    });
+
+    // detach channel 1, so that it opens corresponding thread window.
+    parent.call('mail_service', 'getChannel', 1).detach();
+
+    var $threadWindow = $('.o_thread_window');
+    assert.strictEqual($threadWindow.length, 1,
+        "thread window should be open");
+    assert.strictEqual($threadWindow.data('thread-id'), 1,
+        "thread window should be related to thread ID 1");
+
+    var $header = $threadWindow.find('.o_thread_window_header');
+    assert.strictEqual($header.length, 1,
+        "thread window should have a header");
+
+    var $title = $header.find('.o_thread_window_title');
+    assert.strictEqual($title.length, 1,
+        "thread window should have a title in the header");
+    assert.strictEqual($title.text().trim(), "#general",
+        "should have the title of the general channel");
+
+    var $buttons = $header.find('.o_thread_window_buttons');
+    assert.strictEqual($buttons.length, 1,
+        "should have buttons in the header of the thread window");
+    assert.strictEqual($buttons.find('.o_thread_window_expand').length, 1,
+        "should have a button to expand the thread window");
+    assert.strictEqual($buttons.find('.o_thread_window_close').length, 1,
+        "should have a button to close the thread window");
+
+    assert.strictEqual($threadWindow.find('.o_mail_thread').length, 1,
+        "should display the content of the general channel in the thread window");
+    assert.strictEqual($threadWindow.find('.o_thread_composer').length, 1,
+        "should display a composer in the thread window");
+
+    parent.destroy();
+});
+
+QUnit.test('close thread window using ESCAPE key', function (assert) {
+    assert.expect(5);
+
+    var parent = this.createParent({
+        data: this.data,
+        services: this.services,
+        mockRPC: function (route, args) {
+            if (args.method === 'channel_fold') {
+                assert.ok(true, "should call channel_fold");
+                return $.when();
+            }
+            return this._super.apply(this, arguments);
+        },
+    });
+
+    // get channel instance to link to thread window
+    var channel = parent.call('mail_service', 'getChannel', 1);
+    assert.ok(channel, "there should exist a channel locally with ID 1");
+
+    channel.detach();
+    assert.strictEqual($('.o_thread_window').length, 1,
+        "there should be a thread window that is opened");
+
+    // focus on the thread window and press ESCAPE
+    $('.o_thread_window .o_composer_text_field').click();
+    assert.strictEqual(document.activeElement,
+        $('.o_thread_window .o_composer_text_field')[0],
+        "thread window's input should now be focused");
+
+    var upKeyEvent = $.Event( "keyup", { which: 27 });
+    $('.o_thread_window .o_composer_text_field').trigger(upKeyEvent);
+
+    assert.strictEqual($('.o_thread_window').length, 0,
+        "the thread window should be closed");
+
+    parent.destroy();
+});
+
+QUnit.test('thread window\'s input can still be focused when the UI is blocked', function (assert) {
+    assert.expect(2);
+
+    var parent = this.createParent({
+        data: this.data,
+        services: this.services,
+    });
+
+    var $dom = $('#qunit-fixture');
+
+    // get channel instance to link to thread window
+    var channel = parent.call('mail_service', 'getChannel', 1);
+    channel.detach();
+
+    var $input = $('<input/>', {type: 'text'}).appendTo($dom);
+    $input.focus().click();
+    assert.strictEqual(document.activeElement, $input[0],
+        "fake input should be focused");
+
+    framework.blockUI();
+    // cannot force focus here otherwise the test
+    // makes no sense, this test is just about
+    // making sure that the code which forces the
+    // focus on click is not removed
+    $('.o_thread_window .o_composer_text_field').click();
+    assert.strictEqual(document.activeElement,
+        $('.o_thread_window .o_composer_text_field')[0],
+        "thread window's input should now be focused");
+
+    framework.unblockUI();
+    parent.destroy();
+});
+
+QUnit.test('emoji popover should open correctly in thread windows', function (assert) {
+    assert.expect(1);
+
+    var parent = this.createParent({
+        data: this.data,
+        services: this.services,
+    });
+
+    // get channel instance to link to thread window
+    var channel = parent.call('mail_service', 'getChannel', 1);
+    channel.detach();
+
+    var $emojiButton = $('.o_composer_button_emoji');
+    $emojiButton.trigger('focusin').focus().click();
+    var $popover = $('.o_mail_emoji_container');
+
+    var done = assert.async();
+    // Async is needed as the popover focusout hiding is deferred
+    setTimeout(function () {
+        assert.ok($popover.is(':visible'), "emoji popover should have stayed opened");
+        parent.destroy();
+        done();
+    }, 0);
+});
+
+QUnit.test('do not increase unread counter when receiving message with myself as author', function (assert) {
+    assert.expect(4);
+
+    var generalChannelID = 1;
+    var myselfPartnerID = 44;
+
+    this.data.initMessaging = {
+        channel_slots: {
+            channel_channel: [{
+                id: generalChannelID,
+                channel_type: 'channel',
+                name: "general",
+            }],
+        },
+    };
+
+    var parent = this.createParent({
+        data: this.data,
+        services: this.services,
+        session: { partner_id: myselfPartnerID }
+    });
+
+    // get channel instance to link to thread window
+    var channel = parent.call('mail_service', 'getChannel', 1);
+    channel.detach();
+
+    var threadWindowHeaderText = $('.o_thread_window_header').text().replace(/\s/g, "");
+
+    assert.strictEqual(threadWindowHeaderText, "#general",
+        "thread window header text should not have any unread counter initially");
+    assert.strictEqual(channel.getUnreadCounter(), 0,
+        "thread should have unread counter to 0 initially");
+
+    // simulate receiving message from myself
+    var messageData = {
+        author_id: [myselfPartnerID, "Myself"],
+        body: "<p>Test message</p>",
+        id: 2,
+        model: 'mail.channel',
+        res_id: 1,
+        channel_ids: [1],
+    };
+    var notification = [[false, 'mail.channel', generalChannelID], messageData];
+    parent.call('bus_service', 'trigger', 'notification', [notification]);
+
+    threadWindowHeaderText = $('.o_thread_window_header').text().replace(/\s/g, "");
+
+    assert.strictEqual(threadWindowHeaderText, "#general",
+        "thread window header text should not have any unread counter after receiving my message");
+    assert.strictEqual(channel.getUnreadCounter(), 0,
+        "thread should not have incremented its unread counter after receiving my message");
+
+    parent.destroy();
+});
+
+});
+});
+});