[IMP] mail: refactor activity.js and add some test

activity.js was a little dirty with a lot of copy paste.
Most of the common logic is now in a BasicModel.

This commit also add some tests on activity view

Co-authored-by: RomainLibert <rli@odoo.com>

1 files changed, 316 insertions, 0 deletions

diff --git a/addons/mail/static/tests/activity_tests.js b/addons/mail/static/tests/activity_tests.js
new file mode 100644
index 00000000000..acc59c2f431
--- /dev/null
+++ b/addons/mail/static/tests/activity_tests.js
@@ -0,0 +1,316 @@
+odoo.define('mail.activity_view_tests', function (require) {
+'use strict';
+
+var ActivityView = require('mail.ActivityView');
+var testUtils = require('web.test_utils');
+
+var createView = testUtils.createView;
+var ACTIVITY_DATA = {
+    "grouped_activities":{
+       "13":{
+          "1":{
+             "count":1,
+             "state":"planned",
+             "o_closest_deadline":"2018-08-16",
+             "ids":[
+                1
+             ]
+          }
+       },
+       "30":{
+          "1":{
+             "count":1,
+             "state":"today",
+             "o_closest_deadline":"2018-08-16",
+             "ids":[
+                2
+             ]
+          },
+          "2":{
+             "count":2,
+             "state":"overdue",
+             "o_closest_deadline":"2018-09-16",
+             "ids":[
+                3
+             ]
+          }
+       }
+    },
+    "activity_types":[
+       [
+          1,
+          "Email",
+          [
+             {
+                "id":9,
+                "name":"Task: Rating Request"
+             },
+             {
+                "id":8,
+                "name":"Task: Reception Acknowledgment"
+             }
+          ]
+       ],
+       [
+         2,
+         "Call",
+         []
+      ]
+    ],
+    "model":"task",
+    "res_ids":[
+       [
+          30,
+          "Office planning"
+       ],
+       [
+          13,
+          "Meeting Room Furnitures"
+       ]
+    ]
+};
+
+QUnit.module('mail', {}, function () {
+QUnit.module('activity view', {
+    beforeEach: function () {
+        this.data = {
+            task: {
+                fields: {
+                    id: {string: 'ID', type: 'integer'},
+                },
+                records: [
+                    {id: 13},
+                    {id: 30},
+                ]
+            },
+            partner: {
+                fields: {
+                    display_name: { string: "Displayed name", type: "char" },
+                },
+                records: [{
+                    id: 2,
+                    display_name: "first partner",
+                }]
+            },
+            'mail.activity': {
+                fields: {
+                    activity_type_id: { string: "Activity type", type: "many2one", relation: "mail.activity.type" },
+                    display_name: { string: "Display name", type: "char" },
+                    date_deadline: { string: "Due Date", type: "date" },
+                    state: {
+                        string: 'State',
+                        type: 'selection',
+                        selection: [['overdue', 'Overdue'], ['today', 'Today'], ['planned', 'Planned']],
+                    },
+                    mail_template_ids: { string: "Mail templates", type: "many2many", relation: "mail.template" },
+                    user_id: { string: "Assigned to", type: "many2one", relation: 'partner' },
+                },
+                records:[
+                    {
+                        id: 1,
+                        display_name: "An activity",
+                        date_deadline: moment().add(3, "days").format("YYYY-MM-DD"), // now
+                        state: "planned",
+                        activity_type_id: 1,
+                        mail_template_ids: [8, 9],
+                        user_id:2,
+                    },{
+                        id: 2,
+                        display_name: "An activity",
+                        date_deadline: moment().format("YYYY-MM-DD"), // now
+                        state: "today",
+                        activity_type_id: 1,
+                        mail_template_ids: [8, 9],
+                        user_id:2,
+                    },{
+                        id: 3,
+                        display_name: "An activity",
+                        date_deadline: moment().subtract(2, "days").format("YYYY-MM-DD"), // now
+                        state: "overdue",
+                        activity_type_id: 2,
+                        mail_template_ids: [],
+                        user_id:2,
+                    }
+                ],
+            },
+            'mail.template': {
+                fields: {
+                    name: { string: "Name", type: "char" },
+                },
+                records: [
+                    { id: 8, name: "Template1" },
+                    { id: 9, name: "Template2" },
+                ],
+            },
+            'mail.activity.type': {
+                fields: {
+                    name: { string: "Name", type: "char" },
+                },
+                records: [
+                    { id: 1, name: "Email" },
+                    { id: 2, name: "Call" },
+                ],
+            },
+        };
+    }
+});
+
+QUnit.test('activity view: simple activity rendering', function (assert) {
+    assert.expect(7);
+    var activity = createView({
+        View: ActivityView,
+        model: 'task',
+        data: this.data,
+        arch: '<activity string="Task"/>',
+        mockRPC: function(route, args) {
+            if (args.method === 'get_activity_data') {
+                return $.when(ACTIVITY_DATA);
+            }
+            return this._super(route, args);
+        }
+    });
+
+    assert.strictEqual(activity.$('table').length, 1,
+        'should have a table');
+    assert.ok(activity.$('table thead tr:first th:nth-child(2) span:first:contains(Email)').length,
+        'should contain "Email" in header of first column');
+    assert.ok(activity.$('table thead tr:first th:nth-child(3) span:first:contains(Call)').length,
+        'should contain "Call" in header of second column');
+    assert.ok(activity.$('table tbody tr:first td:first:contains(Office planning)').length,
+        'should contain "Office planning" in first colum of first row');
+    assert.ok(activity.$('table tbody tr:nth-child(2) td:first:contains(Meeting Room Furnitures)').length,
+        'should contain "Meeting Room Furnitures" in first colum of second row');
+    assert.ok(activity.$('table tbody tr:first td:nth-child(2).today .o_closest_deadline:contains(Aug 16)').length,
+        'should contain an activity for today with date Aug 16 in second cell of first line');
+    assert.ok(activity.$('table tbody tr:nth-child(2) td:nth-child(2).planned .o_closest_deadline:contains(Aug 16)').length,
+        'should contain a planned activity with date Aug 16 in second cell of second line');
+    activity.destroy();
+});
+
+QUnit.test('activity view: batch send mail on activity', function (assert) {
+    assert.expect(6);
+    var activity = createView({
+        View: ActivityView,
+        model: 'task',
+        data: this.data,
+        arch: '<activity string="Task"/>',
+        mockRPC: function(route, args) {
+            if (args.method === 'activity_send_mail'){
+                assert.step(args.args);
+                return $.when();
+            }
+            if (args.method === 'get_activity_data') {
+                return $.when(ACTIVITY_DATA);
+            }
+            return this._super(route, args);
+        },
+    });
+    assert.notOk(activity.$('table thead tr:first th:nth-child(2) span:nth-child(2) .dropdown-menu.show').length,
+        'dropdown shouldn\'t be displayed');
+
+    activity.$('table thead tr:first th:nth-child(2) span:nth-child(2) i.fa-ellipsis-v').click();
+    assert.ok(activity.$('table thead tr:first th:nth-child(2) span:nth-child(2) .dropdown-menu.show').length,
+        'dropdown should have appeared');
+
+    activity.$('table thead tr:first th:nth-child(2) span:nth-child(2) .dropdown-menu.show .o_send_mail_template:first:contains(Task: Rating Request)').click();
+    assert.notOk(activity.$('table thead tr:first th:nth-child(2) span:nth-child(2) .dropdown-menu.show').length,
+        'dropdown shouldn\'t be displayed');
+
+    activity.$('table thead tr:first th:nth-child(2) span:nth-child(2) i.fa-ellipsis-v').click();
+    activity.$('table thead tr:first th:nth-child(2) span:nth-child(2) .dropdown-menu.show .o_send_mail_template:nth-child(2):contains(Task: Reception Acknowledgment)').click();
+    assert.verifySteps([
+        [[13, 30], 9], //send mail template 9 on tasl 13 and 30
+        [[13, 30], 8]  //send mail template 8 on tasl 13 and 30
+    ]);
+
+    activity.destroy();
+});
+
+QUnit.test('activity view: activity widget', function (assert) {
+    assert.expect(16);
+    var activity = createView({
+        View: ActivityView,
+        model: 'task',
+        data: this.data,
+        arch: '<activity string="Task"/>',
+        mockRPC: function(route, args) {
+            if (args.method === 'activity_send_mail'){
+                assert.deepEqual([[30],8],args.args, "Should send template 8 on record 30");
+                assert.step('activity_send_mail');
+                return $.when();
+            }
+            if (args.method === 'action_done_schedule_next'){
+                assert.deepEqual([[3]],args.args, "Should execute action_done_schedule_next on activity 3 only ");
+                assert.equal(args.kwargs.feedback, "feedback2");
+                assert.step('action_done_schedule_next');
+                return $.when({serverGeneratedAction: true});
+            }
+            if (args.method === 'get_activity_data') {
+                return $.when(ACTIVITY_DATA);
+            }
+            return this._super(route, args);
+        },
+        intercepts: {
+            do_action: function (ev) {
+                var action = ev.data.action;
+                if (action.serverGeneratedAction) {
+                    assert.step('serverGeneratedAction');
+                } else if (action.res_model === 'mail.compose.message') {
+                    assert.deepEqual({
+                        default_model: "task",
+                        default_res_id: 30,
+                        default_template_id: 8,
+                        default_use_template: true,
+                        force_email: true
+                        }, action.context);
+                    assert.step("do_action_compose");
+                } else if (action.res_model === 'mail.activity') {
+                    assert.deepEqual({
+                        "default_res_id": 30,
+                        "default_res_model": "task"
+                    }, action.context);
+                    assert.step("do_action_activity");
+                } else {
+                    assert.step("Unexpected action");
+                }
+            },
+        }
+    });
+    var today = activity.$('table tbody tr:first td:nth-child(2).today');
+    var dropdown = today.find('.dropdown-menu.o_activity');
+
+    today.find('.o_closest_deadline').click();
+    assert.ok(dropdown.hasClass('show'), "dropdown should be displayed");
+    assert.ok(dropdown.find('.o_activity_color_today:contains(Today)').length, "Title should be today");
+    assert.ok(dropdown.find('.o_activity_title div div div:first span:contains(template8)').length,
+        "template8 should be available");
+    assert.ok(dropdown.find('.o_activity_title div div div:nth-child(2) span:contains(template9)').length,
+        "template9 should be available");
+
+    dropdown.find('.o_activity_title div div div:first .o_activity_template_preview').click();
+    dropdown.find('.o_activity_title div div div:first .o_activity_template_send').click();
+    var overdue = activity.$('table tbody tr:first td:nth-child(3).overdue');
+    overdue.find('.o_closest_deadline').click();
+    dropdown = overdue.find('.dropdown-menu.o_activity');
+    assert.notOk(dropdown.find('.o_activity_title div div div:first span').length,
+        "No template should be available");
+
+    dropdown.find('.o_schedule_activity').click();
+    overdue.find('.o_closest_deadline').click();
+    dropdown.find('.o_mark_as_done').click();
+    dropdown.find('#activity_feedback').val("feedback2");
+
+    dropdown.find('.o_activity_popover_done_next').click();
+    assert.verifySteps([
+        "do_action_compose",
+        "activity_send_mail",
+        "do_action_activity",
+        "action_done_schedule_next",
+        "serverGeneratedAction"
+        ]);
+
+    activity.destroy();
+    });
+
+});
+});