[REF] mail, various: rename subtype parameter of message_post to subtype_xmlid

PURPOSE

Clean posting process and improve mail.message definition and comprehension.

SPECIFICATIONS

In order to be more explicit subtype parameter is renamed to subtype_xmlid.
It therefore clearly indicates it should be a valid subtype Xml ID. Support
of ill formatted Xml IDs is removed because there is no reason to try to
add some random prefix. Give something that exists or go to hell, punk !

LINKS

Task ID 2071556
PR #38692

4 files changed, 5 insertions, 5 deletions

diff --git a/addons/mail/static/src/js/composers/chatter_composer.js b/addons/mail/static/src/js/composers/chatter_composer.js
index 4b20e5b2d25..04a01142ff3 100644
--- a/addons/mail/static/src/js/composers/chatter_composer.js
+++ b/addons/mail/static/src/js/composers/chatter_composer.js
@@ -205,14 +205,14 @@ var ChatterComposer = BasicComposer.extend({
         return new Promise(function (resolve, reject) {
             self._super().then(function (message) {
                 message = _.extend(message, {
-                    subtype: 'mail.mt_comment',
+                    subtype_xmlid: 'mail.mt_comment',
                     message_type: 'comment',
                     context: _.defaults({}, self.context, session.user_context),
                 });
 
                 // Subtype
                 if (self.options.isLog) {
-                    message.subtype = 'mail.mt_note';
+                    message.subtype_xmlid = 'mail.mt_note';
                 }
 
                 // Partner_ids
diff --git a/addons/mail/static/src/js/discuss.js b/addons/mail/static/src/js/discuss.js
index 3d8eda911be..0f2b7feff26 100644
--- a/addons/mail/static/src/js/discuss.js
+++ b/addons/mail/static/src/js/discuss.js
@@ -1496,7 +1496,7 @@ var Discuss = AbstractAction.extend({
         var self = this;
         var options = {};
         if (this._selectedMessage) {
-            messageData.subtype = this._selectedMessage.isNote() ? 'mail.mt_note': 'mail.mt_comment';
+            messageData.subtype_xmlid = this._selectedMessage.isNote() ? 'mail.mt_note': 'mail.mt_comment';
             messageData.subtype_id = false;
             messageData.message_type = 'comment';
 
diff --git a/addons/mail/static/src/js/models/threads/channel.js b/addons/mail/static/src/js/models/threads/channel.js
index 6301018c01f..a47598e3147 100644
--- a/addons/mail/static/src/js/models/threads/channel.js
+++ b/addons/mail/static/src/js/models/threads/channel.js
@@ -443,7 +443,7 @@ var Channel = SearchableThread.extend(ThreadTypingMixin, {
         return this._super.apply(this, arguments).then(function (messageData) {
             _.extend(messageData, {
                 message_type: 'comment',
-                subtype: 'mail.mt_comment',
+                subtype_xmlid: 'mail.mt_comment',
                 command: data.command,
             });
             return self._rpc({
diff --git a/addons/mail/static/src/js/models/threads/document_thread.js b/addons/mail/static/src/js/models/threads/document_thread.js
index cb860b70beb..eefc8f9bd79 100644
--- a/addons/mail/static/src/js/models/threads/document_thread.js
+++ b/addons/mail/static/src/js/models/threads/document_thread.js
@@ -331,7 +331,7 @@ var DocumentThread = Thread.extend({
                 _.extend(messageData, {
                     context: data.context,
                     message_type: data.message_type,
-                    subtype: data.subtype || "mail.mt_comment",
+                    subtype_xmlid: data.subtype_xmlid || "mail.mt_comment",
                     subtype_id: data.subtype_id,
                 });
                 return self._rpc({