diff options
| author | Luis González <lgonzalez@vauxoo.com> | 2020-03-21 23:43:29 +0000 |
|---|---|---|
| committer | Nicolas Lempereur <nle@odoo.com> | 2020-03-25 12:39:02 +0000 |
| commit | 5dda9a709eb93af7de5b184cb823b0ebeaad2db1 (patch) | |
| tree | 99fd4d7dc2850e03b7bbad68f433d85b22fb27d0 /addons/mail/static/src/xml | |
| parent | 52a98f74f309338181fe8e4491905aaaec085bbe (diff) | |
[FIX] web,mail: Harmful or incomplete aria-label attributes
Some elements contain superfluous `aria-label` attributes, which
overrides any default useful information. For instance, some dropdown
menus contain the `aria-label` "Dropdown menu" (e.g. the company
switcher), which doesn't add any useful information, as dropdown menus
are already labelled correctly using `aria-expanded`.
This change applies on the following buttons:
- Schedule an activity
- View attachments
- View followers
- Switch company
- Open user options from systray
- The widget `state_selection`
closes odoo/odoo#48317
X-original-commit: e3c7f66e89d7be39dfa4cc3d6b038c6f4a114aa5
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Diffstat (limited to 'addons/mail/static/src/xml')
| -rw-r--r-- | addons/mail/static/src/xml/chatter.xml | 5 | ||||
| -rw-r--r-- | addons/mail/static/src/xml/followers.xml | 2 |
2 files changed, 4 insertions, 3 deletions
diff --git a/addons/mail/static/src/xml/chatter.xml b/addons/mail/static/src/xml/chatter.xml index 40e26a811b0..1f36287cdf8 100644 --- a/addons/mail/static/src/xml/chatter.xml +++ b/addons/mail/static/src/xml/chatter.xml @@ -119,7 +119,7 @@ Log note </button> <button t-if="scheduleActivityButton" class="btn btn-link o_chatter_button_schedule_activity" title="Log or schedule an activity" disabled="disabled"> - <i class="fa fa-clock-o" role="img" aria-label="Dates" title="Dates"/> <t t-if="isMobile">Activity</t><t t-else="">Schedule activity</t> + <i class="fa fa-clock-o" title="Dates"/> <t t-if="isMobile">Activity</t><t t-else="">Schedule activity</t> </button> </t> @@ -129,7 +129,8 @@ @param {integer} [count] --> <t t-name="mail.chatter.Attachment.Button"> - <button class="btn btn-link o_chatter_button_attachment" title="View all the attachments of the current record"> + <t t-set="attachment_button_aria_label">Attachments</t> + <button class="btn btn-link o_chatter_button_attachment" title="View all the attachments of the current record" t-attf-aria-label="#{attachment_button_aria_label} #{count}"> <span> <i class="fa fa-paperclip"/> <span class="o_chatter_attachment_button_count" t-esc="count"/> diff --git a/addons/mail/static/src/xml/followers.xml b/addons/mail/static/src/xml/followers.xml index 8789b424af2..d1f6ebd63a4 100644 --- a/addons/mail/static/src/xml/followers.xml +++ b/addons/mail/static/src/xml/followers.xml @@ -9,7 +9,7 @@ <div class="o_followers_title_box btn-group"> <button class="btn btn-link" title="Dropdown menu - Followers" data-toggle="dropdown" aria-expanded="false"> - <i class="fa fa-user" role="img" aria-label="Dropdown menu - Followers"></i> + <i class="fa fa-user" role="img" aria-label="Followers"></i> <span class="o_followers_count"/> </button> <div class="dropdown-menu dropdown-menu-right o_followers_list" role="menu"/> |