diff options
| author | kujiu <kujiu@users.noreply.github.com> | 2018-07-04 09:55:52 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-07-04 09:55:52 +0200 |
| commit | f90cf060a3cfeb37a67bec83264c0aaab8892b56 (patch) | |
| tree | fb92375b6d60293cdb49fe2e61fc20bddcd30940 /addons/mail/static/src/xml/discuss.xml | |
| parent | ad0f8fd0b7a468538dfb3bb8c08743913b886e78 (diff) | |
[FIX] Syntax of icons (#25577)
Description of the issue/feature this PR addresses:
Accessibility improvements forbids the use of the syntax
`<i class="fa fa-check"/> Some text`
to create a labelled icon. But, by this, some fonts are changed.
Desired behavior after PR is merged:
The old syntax can be used.
Diffstat (limited to 'addons/mail/static/src/xml/discuss.xml')
| -rw-r--r-- | addons/mail/static/src/xml/discuss.xml | 16 |
1 files changed, 10 insertions, 6 deletions
diff --git a/addons/mail/static/src/xml/discuss.xml b/addons/mail/static/src/xml/discuss.xml index 493d3c918aa..ff5d7d1d66a 100644 --- a/addons/mail/static/src/xml/discuss.xml +++ b/addons/mail/static/src/xml/discuss.xml @@ -30,13 +30,13 @@ <div class="o_mail_discuss_sidebar"> <div t-attf-class="o_mail_discuss_title_main o_mail_discuss_item #{(activeThreadID === 'mailbox_inbox') ? 'o_active': ''}" data-thread-id="mailbox_inbox"> - <span class="o_thread_name fa fa-inbox mr8">Inbox</span> + <span class="o_channel_name"><i class="fa fa-inbox mr8"/>Inbox</span> <t t-set="counter" t-value="needactionCounter"/> <t t-call="mail.discuss.SidebarCounter"/> </div> <div t-attf-class="o_mail_discuss_title_main o_mail_mailbox_title_starred o_mail_discuss_item #{(activeThreadID === 'mailbox_starred') ? 'o_active': ''}" data-thread-id="mailbox_starred"> - <span class="o_thread_name fa fa-star-o mr8">Starred</span> + <span class="o_channel_name"><i class="fa fa-star-o mr8"/>Starred</span> <t t-set="counter" t-value="starredCounter"/> <t t-call="mail.discuss.SidebarCounter"/> </div> @@ -218,16 +218,20 @@ <div class="o_mail_discuss_content"/> <div class="o_mail_mobile_tabs"> <div class="o_mail_mobile_tab" data-type="mailbox_inbox"> - <span class="o_tab_title fa fa-inbox">Inbox</span> + <span class="fa fa-inbox"/> + <span class="o_tab_title">Inbox</span> </div> <div class="o_mail_mobile_tab" data-type="dm"> - <span class="o_tab_title fa fa-user">Chat</span> + <span class="fa fa-user"/> + <span class="o_tab_title">Chat</span> </div> <div class="o_mail_mobile_tab" data-type="public"> - <span class="o_tab_title fa fa-users">Channels</span> + <span class="fa fa-users"/> + <span class="o_tab_title">Channels</span> </div> <div class="o_mail_mobile_tab" data-type="private"> - <span class="o_tab_title fa fa-eye-slash">Private Channels</span> + <span class="fa fa-eye-slash"/> + <span class="o_tab_title">Private Channels</span> </div> </div> </div> |
