diff options
| author | qsm-odoo <qsm@odoo.com> | 2018-02-15 18:14:58 +0100 |
|---|---|---|
| committer | qsm-odoo <qsm@odoo.com> | 2018-04-18 15:59:18 +0200 |
| commit | fbfd0119041ca7dc830796e76d9ae5c303459d4f (patch) | |
| tree | e30dd1a85988a97411a6d00945248fa1166cf465 /addons/mail/static/src/scss | |
| parent | 97aa0a8dec384ad75eb66045f43384b6e54f1d6e (diff) | |
[REF] *: get rid of introduced @extend
During first scss convertion, classes called as mixins were changed to
an @extend instruction which was the best approximation given the fact
there is no equivalent in sass to do that. The problem is that the
instruction is slowing the scss computation a lot and might also break
the style in unexpected ways because of the complex unwanted selectors
the instruction induces.
This commit removes the need of extends. This is done case per case.
Sometimes this involves adding classes in xml, sometimes to change the
style a little, ... The button rendering refactoring which was made
at the start of the LESS to SASS merge was also done in prevision of
this.
After this commit, sass computation is like 5-6 times faster than less
computation while it was like 10 times *slower* before this commit.
Diffstat (limited to 'addons/mail/static/src/scss')
| -rw-r--r-- | addons/mail/static/src/scss/systray.scss | 2 | ||||
| -rw-r--r-- | addons/mail/static/src/scss/thread.scss | 4 |
2 files changed, 0 insertions, 6 deletions
diff --git a/addons/mail/static/src/scss/systray.scss b/addons/mail/static/src/scss/systray.scss index 958e1ff2c08..c06bde1d3f1 100644 --- a/addons/mail/static/src/scss/systray.scss +++ b/addons/mail/static/src/scss/systray.scss @@ -45,7 +45,6 @@ border-bottom: 1px solid $gray-lighter-darker; box-shadow: 0 0 2px $gray-lighter-darker; .o_filter_button, .o_new_message { - @extend .btn-link; // FIXME was a mixin before scss convertion padding: 5px; } .o_filter_button { @@ -87,7 +86,6 @@ } } .o_activity_filter_button { - @extend .btn-link; // FIXME was a mixin before scss convertion padding: 2px; } .o_no_activity { diff --git a/addons/mail/static/src/scss/thread.scss b/addons/mail/static/src/scss/thread.scss index 9f9ace65de9..4a2edb68913 100644 --- a/addons/mail/static/src/scss/thread.scss +++ b/addons/mail/static/src/scss/thread.scss @@ -144,10 +144,6 @@ .o_mail_info { margin-bottom: 2px; - @extend .text-muted; // FIXME was a mixin before scss convertion - .o_mail_mailto, .o_mail_mailto:hover { - @extend .text-muted; // FIXME was a mixin before scss convertion - } strong { color: $headings-color; |