[FIX] mail: handles unlink button spam on attachments

Before this commit, attempting to delete attachments multiple times
could result in errors, especially on slow networks.

This commit fixes this issue.

task-2363522

closes odoo/odoo#61017

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

1 files changed, 19 insertions, 5 deletions

diff --git a/addons/mail/static/src/models/attachment/attachment.js b/addons/mail/static/src/models/attachment/attachment.js
index 7399dee7b33..3cea681a3bf 100644
--- a/addons/mail/static/src/models/attachment/attachment.js
+++ b/addons/mail/static/src/models/attachment/attachment.js
@@ -97,12 +97,20 @@ function factory(dependencies) {
          * Remove this attachment globally.
          */
         async remove() {
+            if (this.isUnlinkPending) {
+                return;
+            }
             if (!this.isTemporary) {
-                await this.async(() => this.env.services.rpc({
-                    model: 'ir.attachment',
-                    method: 'unlink',
-                    args: [this.id],
-                }, { shadow: true }));
+                this.update({ isUnlinkPending: true });
+                try {
+                    await this.async(() => this.env.services.rpc({
+                        model: 'ir.attachment',
+                        method: 'unlink',
+                        args: [this.id],
+                    }, { shadow: true }));
+                } finally {
+                    this.update({ isUnlinkPending: false });
+                }
             } else if (this.uploadingAbortController) {
                 this.uploadingAbortController.abort();
             }
@@ -333,6 +341,12 @@ function factory(dependencies) {
             compute: '_computeIsTextFile',
             dependencies: ['fileType'],
         }),
+        /**
+         * True if an unlink RPC is pending, used to prevent multiple unlink attempts.
+         */
+        isUnlinkPending: attr({
+            default: false,
+        }),
         isViewable: attr({
             compute: '_computeIsViewable',
             dependencies: [