[FIX] mail: avoid a stack overflow during loading

When the amount of mail messages is big enough (about 1500?), the
recursion goes deeper and deeper, until the Javascript limit raises an
infinite recursion error.

This commit fixes the issue by avoiding to run an inner
_flushUpdateCycle with the update if the change is not needed, so the
second time that it is reached it does not start a new update, which
would have run another flush update cycle.

closes odoo/odoo#62076

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

1 files changed, 3 insertions, 1 deletions

diff --git a/addons/mail/static/src/models/thread_cache/thread_cache.js b/addons/mail/static/src/models/thread_cache/thread_cache.js
index 5ca4443df5f..8383936a3f1 100644
--- a/addons/mail/static/src/models/thread_cache/thread_cache.js
+++ b/addons/mail/static/src/models/thread_cache/thread_cache.js
@@ -195,7 +195,9 @@ function factory(dependencies) {
             }
             const wasCacheRefreshRequested = this.isCacheRefreshRequested;
             // mark hint as processed
-            this.update({ isCacheRefreshRequested: false });
+            if (this.isCacheRefreshRequested) {
+                this.update({ isCacheRefreshRequested: false });
+            }
             if (this.thread.isTemporary) {
                 // temporary threads don't exist on the server
                 return false;