summaryrefslogtreecommitdiff
path: root/addons/mail/static/src/models/messaging_notification_handler
diff options
context:
space:
mode:
authorXavier Dubuc <xdu@odoo.com>2020-09-03 16:24:19 +0000
committerSébastien Theys <seb@odoo.com>2020-09-04 14:59:01 +0000
commit8d3413ff647de8d98c6858062dd07dde4160af95 (patch)
tree3dc134e83c874d5c7f7bf739f13a88ab986ddb1b /addons/mail/static/src/models/messaging_notification_handler
parenta5ab687be4e7890262ce9429e18dd011021513d5 (diff)
[FIX] mail, sms, snailmail: prevent message_fetch for hidden threads
Automatically load messages from a thread cache only if the thread cache is used in at least one thread view. Ensure thread viewer don't keep thread view records alive when they are not displayed. This change is particularly important for performance, to avoid spamming RPC at init if many threads are opened in chat windows. task-2310623 closes odoo/odoo#57061 X-original-commit: dd6981c7812134e0588f80a157eaba45512cd68e Related: odoo/enterprise#12936 Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Diffstat (limited to 'addons/mail/static/src/models/messaging_notification_handler')
-rw-r--r--addons/mail/static/src/models/messaging_notification_handler/messaging_notification_handler.js14
1 files changed, 13 insertions, 1 deletions
diff --git a/addons/mail/static/src/models/messaging_notification_handler/messaging_notification_handler.js b/addons/mail/static/src/models/messaging_notification_handler/messaging_notification_handler.js
index 29923af1e39..0ce0279e87d 100644
--- a/addons/mail/static/src/models/messaging_notification_handler/messaging_notification_handler.js
+++ b/addons/mail/static/src/models/messaging_notification_handler/messaging_notification_handler.js
@@ -155,6 +155,10 @@ function factory(dependencies) {
// knowledge of the channel
return;
}
+ if (channel.channel_type === 'channel') {
+ // disabled on `channel` channels for performance reasons
+ return;
+ }
channel.update({
partnerSeenInfos: [['insert',
{
@@ -259,7 +263,11 @@ function factory(dependencies) {
message,
});
}
- channel.markAsFetched();
+ if (channel.model === 'mail.channel' && channel.channel_type !== 'channel') {
+ // disabled on non-channel threads and
+ // on `channel` channels for performance reasons
+ channel.markAsFetched();
+ }
// (re)open chat on receiving new message
if (channel.channel_type !== 'channel') {
this.env.messaging.chatWindowManager.openThread(channel);
@@ -303,6 +311,10 @@ function factory(dependencies) {
// knowledge of the channel
return;
}
+ if (channel.channel_type === 'channel') {
+ // disabled on `channel` channels for performance reasons
+ return;
+ }
const lastMessage = this.env.models['mail.message'].insert({id: last_message_id});
const updateData = {
partnerSeenInfos: [['insert',