diff options
| author | Alexandre Kühn <aku@odoo.com> | 2018-11-14 20:19:59 +0000 |
|---|---|---|
| committer | Alexandre Kühn <aku@odoo.com> | 2018-11-14 20:29:29 +0000 |
| commit | 2b245ebb436a6880f05e25c65470bd48c3eea4a5 (patch) | |
| tree | d3068786ef73cf5a8eb290fe8657b30f08467d01 /addons/mail/static/src/js/models/threads | |
| parent | 774991946e491ee1c7fdf772405bc0e2c111fdaa (diff) | |
[FIX] mail: no crash on grouped inbox messages previews
Revision on https://github.com/odoo/odoo/commit/5f8d3c61bee40d027efc5041cdc4bca5e67c42d7
Before this commit, there was a traceback when you had two needaction
notifications related to the same document.
This is caused by a typo in the commit above: the object `similarItem`
has a property `messageIDs`, but the code wrongly access the property
`messagesIDs` (see the extra "s").
Steps to reproduce:
- Set notification management to 'Handle with Odoo' for Admin
- Demo mention Admin twice on a specific project task
- Admin opens messaging menu
Display error `Cannot read property 'concat' of undefined`
Issue reported on this PR comment: https://github.com/odoo/odoo/pull/28462#pullrequestreview-175001349
Task-ID 1909521
closes odoo/odoo#28703
Diffstat (limited to 'addons/mail/static/src/js/models/threads')
| -rw-r--r-- | addons/mail/static/src/js/models/threads/mailbox.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/addons/mail/static/src/js/models/threads/mailbox.js b/addons/mail/static/src/js/models/threads/mailbox.js index 8d49d84d777..82d65bdd6cc 100644 --- a/addons/mail/static/src/js/models/threads/mailbox.js +++ b/addons/mail/static/src/js/models/threads/mailbox.js @@ -82,7 +82,7 @@ var Mailbox = SearchableThread.extend({ }); if (similarItem) { unreadCounter = similarItem.unreadCounter + 1; - messageIDs = similarItem.messagesIDs.concat(messageIDs); + messageIDs = similarItem.messageIDs.concat(messageIDs); var index = _.findIndex(items, similarItem); items[index] = { unreadCounter: unreadCounter, |