summaryrefslogtreecommitdiff
path: root/addons/mail/static/src/components/messaging_menu/messaging_menu.js
diff options
context:
space:
mode:
authorSébastien Theys <seb@odoo.com>2020-06-23 17:03:08 +0000
committerSébastien Theys <seb@odoo.com>2020-06-24 10:22:58 +0000
commit652d835f77da3e19eeb70a4a2fec46fd9bff8b46 (patch)
tree4811bc7e65eaacb5ad29eb715baac266567765d5 /addons/mail/static/src/components/messaging_menu/messaging_menu.js
parentba744be93748063ac9b051509d99f6b582e0df20 (diff)
[FIX] mail: restore close of other menus on click of messaging menu
task-2278830 closes odoo/odoo#53566 X-original-commit: 0407151b34da16ca54066bb15e578dc1db85f365 Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com> Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Diffstat (limited to 'addons/mail/static/src/components/messaging_menu/messaging_menu.js')
-rw-r--r--addons/mail/static/src/components/messaging_menu/messaging_menu.js10
1 files changed, 5 insertions, 5 deletions
diff --git a/addons/mail/static/src/components/messaging_menu/messaging_menu.js b/addons/mail/static/src/components/messaging_menu/messaging_menu.js
index 864c7df97e1..b4647d698cc 100644
--- a/addons/mail/static/src/components/messaging_menu/messaging_menu.js
+++ b/addons/mail/static/src/components/messaging_menu/messaging_menu.js
@@ -113,6 +113,8 @@ class MessagingMenu extends Component {
//--------------------------------------------------------------------------
/**
+ * Closes the menu when clicking outside, if appropriate.
+ *
* @private
* @param {MouseEvent} ev
*/
@@ -126,7 +128,7 @@ class MessagingMenu extends Component {
) {
return;
}
- // closes the menu when clicking outside
+ // ignore click inside the menu
if (this.el.contains(ev.target)) {
return;
}
@@ -142,7 +144,6 @@ class MessagingMenu extends Component {
* @param {MouseEvent} ev
*/
_onClickDesktopTabButton(ev) {
- ev.stopPropagation();
this.messagingMenu.update({ activeTabId: ev.currentTarget.dataset.tabId });
}
@@ -151,9 +152,8 @@ class MessagingMenu extends Component {
* @param {MouseEvent} ev
*/
_onClickNewMessage(ev) {
- ev.stopPropagation();
if (!this.env.messaging.device.isMobile) {
- this.env.models['mail.thread'].openNewMessage();
+ this.env.messaging.chatWindowManager.openNewMessage();
this.messagingMenu.close();
} else {
this.messagingMenu.toggleMobileNewMessage();
@@ -165,7 +165,7 @@ class MessagingMenu extends Component {
* @param {MouseEvent} ev
*/
_onClickToggler(ev) {
- ev.stopPropagation();
+ // avoid following dummy href
ev.preventDefault();
this.messagingMenu.toggleOpen();
}