summaryrefslogtreecommitdiff
path: root/addons/mail/static/src/components/chat_window_header
diff options
context:
space:
mode:
authorSébastien Theys <seb@odoo.com>2021-01-21 17:43:49 +0000
committerSébastien Theys <seb@odoo.com>2021-01-21 17:43:49 +0000
commit7f9af5747c7b650b6cf4ab894bdd0b113e77a78b (patch)
tree5152dca1d14355e7c7465b41fcbe9c80770e98a6 /addons/mail/static/src/components/chat_window_header
parent47bfdf0592a5dd93870ca1a9da326351d70087bb (diff)
[FIX] mail, *: significantly reduce number of useless renders
* = hr_holidays, im_livechat, website_livechat A huge amount of components where rendered for no reason, notably when typing a new message (at every key press), which significantly slowed down the interface. There were 2 causes to this number of renders: - OWL rendering all children automatically, even if their props didn't change, unless `shouldUpdate` is overridden, which is now done. - `useStore` selectors being way too generous in what they observed task-2399731 closes odoo/odoo#62703 Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Diffstat (limited to 'addons/mail/static/src/components/chat_window_header')
-rw-r--r--addons/mail/static/src/components/chat_window_header/chat_window_header.js11
1 files changed, 9 insertions, 2 deletions
diff --git a/addons/mail/static/src/components/chat_window_header/chat_window_header.js b/addons/mail/static/src/components/chat_window_header/chat_window_header.js
index 5b1d2e88b2b..eb41190b1e8 100644
--- a/addons/mail/static/src/components/chat_window_header/chat_window_header.js
+++ b/addons/mail/static/src/components/chat_window_header/chat_window_header.js
@@ -4,6 +4,7 @@ odoo.define('mail/static/src/components/chat_window_header/chat_window_header.js
const components = {
ThreadIcon: require('mail/static/src/components/thread_icon/thread_icon.js'),
};
+const useShouldUpdateBasedOnProps = require('mail/static/src/component_hooks/use_should_update_based_on_props/use_should_update_based_on_props.js');
const useStore = require('mail/static/src/component_hooks/use_store/use_store.js');
const { Component } = owl;
@@ -15,13 +16,19 @@ class ChatWindowHeader extends Component {
*/
constructor(...args) {
super(...args);
+ useShouldUpdateBasedOnProps();
useStore(props => {
const chatWindow = this.env.models['mail.chat_window'].get(props.chatWindowLocalId);
const thread = chatWindow && chatWindow.thread;
return {
- chatWindow: chatWindow ? chatWindow.__state : undefined,
+ chatWindow,
+ chatWindowHasShiftLeft: chatWindow && chatWindow.hasShiftLeft,
+ chatWindowHasShiftRight: chatWindow && chatWindow.hasShiftRight,
+ chatWindowName: chatWindow && chatWindow.name,
isDeviceMobile: this.env.messaging.device.isMobile,
- thread: thread ? thread.__state : undefined,
+ thread,
+ threadLocalMessageUnreadCounter: thread && thread.localMessageUnreadCounter,
+ threadMassMailing: thread && thread.mass_mailing,
};
});
}