summaryrefslogtreecommitdiff
path: root/addons/mail/models/mail_activity.py
diff options
context:
space:
mode:
authorAdrian Torres <adt@odoo.com>2019-07-10 14:59:37 +0200
committerAdrian Torres <adt@odoo.com>2019-07-17 14:13:12 +0200
commit4b38cc6590abcb58a0ca102a06063eb3db7ac1f4 (patch)
treecfd11739fc6b4c0cb4b23b54cc6badad4bf5c55e /addons/mail/models/mail_activity.py
parentf6fdde96bddfedf8764cd8a73089e44340d476ae (diff)
[REM] *: calls to @api.multi
Multi is the default api for methods, it is not necessary to explicitly decorate methods with it, adds clutter and most people use it because they see that the rest of the code uses it. Done with `find . -type f -name '*.py' | xargs sed -i '/@api.multi/d'`
Diffstat (limited to 'addons/mail/models/mail_activity.py')
-rw-r--r--addons/mail/models/mail_activity.py15
1 files changed, 0 insertions, 15 deletions
diff --git a/addons/mail/models/mail_activity.py b/addons/mail/models/mail_activity.py
index 97ef1011eff..566c994d75d 100644
--- a/addons/mail/models/mail_activity.py
+++ b/addons/mail/models/mail_activity.py
@@ -90,7 +90,6 @@ class MailActivityType(models.Model):
for activity_type in self:
activity_type.initial_res_model_id = activity_type.res_model_id
- @api.multi
def unlink(self):
if any(self.get_external_id().values()):
raise exceptions.ValidationError("You can not delete activity type that are used as master data.")
@@ -160,13 +159,11 @@ class MailActivity(models.Model):
# access
can_write = fields.Boolean(compute='_compute_can_write', help='Technical field to hide buttons if the current user has no access.')
- @api.multi
@api.onchange('previous_activity_type_id')
def _compute_has_recommended_activities(self):
for record in self:
record.has_recommended_activities = bool(record.previous_activity_type_id.next_type_ids)
- @api.multi
@api.onchange('previous_activity_type_id')
def _onchange_previous_activity_type_id(self):
for record in self:
@@ -226,7 +223,6 @@ class MailActivity(models.Model):
if self.recommended_activity_type_id:
self.activity_type_id = self.recommended_activity_type_id
- @api.multi
def _filter_access_rules(self, operation):
""" Return the subset of ``self`` for which ``operation`` is allowed.
A custom implementation is done on activities as this document has some
@@ -282,7 +278,6 @@ class MailActivity(models.Model):
return valid
- @api.multi
def _check_access_assignation(self):
""" Check assigned user (user_id field) has access to the document. Purpose
is to allow assigned user to handle their activities. For that purpose
@@ -334,7 +329,6 @@ class MailActivity(models.Model):
{'type': 'activity_updated', 'activity_created': True})
return activity
- @api.multi
def write(self, values):
if values.get('user_id'):
user_changes = self.filtered(lambda activity: activity.user_id.id != values.get('user_id'))
@@ -361,7 +355,6 @@ class MailActivity(models.Model):
{'type': 'activity_updated', 'activity_deleted': True})
return res
- @api.multi
def unlink(self):
for activity in self:
if activity.date_deadline <= fields.Date.today():
@@ -374,7 +367,6 @@ class MailActivity(models.Model):
# Business Methods
# ------------------------------------------------------
- @api.multi
def action_notify(self):
if not self:
return
@@ -397,14 +389,12 @@ class MailActivity(models.Model):
email_layout_xmlid='mail.mail_notification_light',
)
- @api.multi
def action_done(self):
""" Wrapper without feedback because web button add context as
parameter, therefore setting context to feedback """
messages, next_activities = self._action_done()
return messages.ids and messages.ids[0] or False
- @api.multi
def action_feedback(self, feedback=False, attachment_ids=None):
messages, next_activities = self._action_done(feedback=feedback, attachment_ids=attachment_ids)
return messages.ids and messages.ids[0] or False
@@ -414,7 +404,6 @@ class MailActivity(models.Model):
parameter, therefore setting context to feedback """
return self.action_feedback_schedule_next()
- @api.multi
def action_feedback_schedule_next(self, feedback=False):
ctx = dict(
clean_context(self.env.context),
@@ -485,7 +474,6 @@ class MailActivity(models.Model):
return messages, next_activities
- @api.multi
def action_close_dialog(self):
return {'type': 'ir.actions.act_window_close'}
@@ -636,7 +624,6 @@ class MailActivityMixin(models.AbstractModel):
def _search_activity_summary(self, operator, operand):
return [('activity_ids.summary', operator, operand)]
- @api.multi
def write(self, vals):
# Delete activities of archived record.
if 'active' in vals and vals['active'] is False:
@@ -645,7 +632,6 @@ class MailActivityMixin(models.AbstractModel):
).unlink()
return super(MailActivityMixin, self).write(vals)
- @api.multi
def unlink(self):
""" Override unlink to delete records activities through (res_model, res_id). """
record_ids = self.ids
@@ -655,7 +641,6 @@ class MailActivityMixin(models.AbstractModel):
).unlink()
return result
- @api.multi
def toggle_active(self):
""" Before archiving the record we should also remove its ongoing
activities. Otherwise they stay in the systray and concerning archived