[IMP] mail: track fields based on ir_model_fields

The tracked field is now a relation to the corresponding ir.model.field.
This prevents potential privacy issues should the field be deleted or renamed.

closes odoo/odoo#39232

Taskid: 2088634
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

1 files changed, 0 insertions, 19 deletions

diff --git a/addons/mail/models/ir_model_fields.py b/addons/mail/models/ir_model_fields.py
index bf9ff3e2de2..e8650ce2d6d 100644
--- a/addons/mail/models/ir_model_fields.py
+++ b/addons/mail/models/ir_model_fields.py
@@ -30,22 +30,3 @@ class IrModelField(models.Model):
         if attrs and field_data.get('tracking'):
             attrs['tracking'] = field_data['tracking']
         return attrs
-
-    def unlink(self):
-        """
-        Delete 'mail.tracking.value's when a module is uninstalled
-        """
-        if self:
-            query = """
-                DELETE FROM mail_tracking_value
-                WHERE id IN (
-                    SELECT t.id
-                    FROM mail_tracking_value t
-                    INNER JOIN mail_message m ON (m.id = t.mail_message_id)
-                    INNER JOIN ir_model_fields f ON (t.field = f.name AND m.model = f.model)
-                    WHERE f.id IN %s
-                );
-            """
-            self.flush()
-            self.env.cr.execute(query, (tuple(self.ids),))
-        return super(IrModelField, self).unlink()