summaryrefslogtreecommitdiff
path: root/addons/link_tracker/models/link_tracker.py
diff options
context:
space:
mode:
authorDenis Ledoux <dle@odoo.com>2017-02-21 12:20:51 +0100
committerDenis Ledoux <dle@odoo.com>2017-02-21 12:26:02 +0100
commitb7dffb59ffcf784b389bac6f4578ae071645b66d (patch)
tree66389e43da9df43c853017193177edee9e9c51b3 /addons/link_tracker/models/link_tracker.py
parent3598538b571d1266699985ecf195c88b6f2925f7 (diff)
[FIX] link_tracker: convert link with ampersand
Links containing HTML escaped characters, such as the ampersand `&` escaped `&amp;` were not shortened correctly: Their redirecting URL contained the escaped value (e.g. `&amp;`) instead of the actual character, leading to the wrong redirected URL. e.g. creating a mass-mailing with a link contains as query string ?test1=1&test2=2 were shortened with as redirect link ?test1=1&amp;test2=2 opw-708272
Diffstat (limited to 'addons/link_tracker/models/link_tracker.py')
-rw-r--r--addons/link_tracker/models/link_tracker.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/addons/link_tracker/models/link_tracker.py b/addons/link_tracker/models/link_tracker.py
index 4de629fc517..dd8432f3306 100644
--- a/addons/link_tracker/models/link_tracker.py
+++ b/addons/link_tracker/models/link_tracker.py
@@ -8,7 +8,7 @@ from lxml import html
from urllib2 import urlopen
from urlparse import urljoin
from urlparse import urlparse
-from werkzeug import url_encode
+from werkzeug import url_encode, unescape
from openerp import models, fields, api, _
from openerp.tools import ustr
@@ -54,7 +54,7 @@ class link_tracker(models.Model):
href = match[0]
long_url = match[1]
- vals['url'] = long_url
+ vals['url'] = unescape(long_url)
if not blacklist or not [s for s in blacklist if s in long_url] and not long_url.startswith(short_schema):
link = self.create(vals)