[FIX] l10n_*: fix taxes repartition so that 12.3 matches what is defined in 12.2

[IMP] l10n_*: don't define accounts or tags on tax repartition line templates anymore for 0% taxes

[FIX] account: remove old function used to migrate the former tax model, incompatible with the new one

2 files changed, 10 insertions, 20 deletions

diff --git a/addons/l10n_vn/data/account_tax_data.xml b/addons/l10n_vn/data/account_tax_data.xml
index 134cb99d16b..c7c549f3544 100644
--- a/addons/l10n_vn/data/account_tax_data.xml
+++ b/addons/l10n_vn/data/account_tax_data.xml
@@ -14,26 +14,26 @@
                 (0,0, {
                     'factor_percent': 100,
                     'repartition_type': 'base',
-                    'minus_report_line_ids': [ref('account_tax_report_line_03_02_01_vn')],
+                    'plus_report_line_ids': [ref('account_tax_report_line_03_02_01_vn')],
                 }),
                 (0,0, {
                     'factor_percent': 100,
                     'repartition_type': 'tax',
                     'account_id': ref('chart1331'),
-                    'minus_report_line_ids': [ref('account_tax_report_line_03_01_01_vn')],
+                    'plus_report_line_ids': [ref('account_tax_report_line_03_01_01_vn')],
                 }),
             ]"/>
         <field name="refund_repartition_line_ids" eval="[(5, 0, 0),
                 (0,0, {
                     'factor_percent': 100,
                     'repartition_type': 'base',
-                    'plus_report_line_ids': [ref('account_tax_report_line_03_02_01_vn')],
+                    'minus_report_line_ids': [ref('account_tax_report_line_03_02_01_vn')],
                 }),
                 (0,0, {
                     'factor_percent': 100,
                     'repartition_type': 'tax',
                     'account_id': ref('chart1331'),
-                    'plus_report_line_ids': [ref('account_tax_report_line_03_01_01_vn')],
+                    'minus_report_line_ids': [ref('account_tax_report_line_03_01_01_vn')],
                 }),
             ]"/>
     </record>
@@ -49,26 +49,26 @@
                 (0,0, {
                     'factor_percent': 100,
                     'repartition_type': 'base',
-                    'minus_report_line_ids': [ref('account_tax_report_line_02_02_01_vn')],
+                    'plus_report_line_ids': [ref('account_tax_report_line_02_02_01_vn')],
                 }),
                 (0,0, {
                     'factor_percent': 100,
                     'repartition_type': 'tax',
                     'account_id': ref('chart1331'),
-                    'minus_report_line_ids': [ref('account_tax_report_line_02_01_01_vn')],
+                    'plus_report_line_ids': [ref('account_tax_report_line_02_01_01_vn')],
                 }),
             ]"/>
         <field name="refund_repartition_line_ids" eval="[(5, 0, 0),
                 (0,0, {
                     'factor_percent': 100,
                     'repartition_type': 'base',
-                    'plus_report_line_ids': [ref('account_tax_report_line_02_02_01_vn')],
+                    'minus_report_line_ids': [ref('account_tax_report_line_02_02_01_vn')],
                 }),
                 (0,0, {
                     'factor_percent': 100,
                     'repartition_type': 'tax',
                     'account_id': ref('chart1331'),
-                    'plus_report_line_ids': [ref('account_tax_report_line_02_01_01_vn')],
+                    'minus_report_line_ids': [ref('account_tax_report_line_02_01_01_vn')],
                 }),
             ]"/>
     </record>
@@ -84,24 +84,22 @@
                 (0,0, {
                     'factor_percent': 100,
                     'repartition_type': 'base',
-                    'minus_report_line_ids': [ref('account_tax_report_line_01_02_01_vn')],
+                    'plus_report_line_ids': [ref('account_tax_report_line_01_02_01_vn')],
                 }),
                 (0,0, {
                     'factor_percent': 100,
                     'repartition_type': 'tax',
-                    'account_id': ref('chart1331'),
                 }),
             ]"/>
         <field name="refund_repartition_line_ids" eval="[(5, 0, 0),
                 (0,0, {
                     'factor_percent': 100,
                     'repartition_type': 'base',
-                    'plus_report_line_ids': [ref('account_tax_report_line_01_02_01_vn')],
+                    'minus_report_line_ids': [ref('account_tax_report_line_01_02_01_vn')],
                 }),
                 (0,0, {
                     'factor_percent': 100,
                     'repartition_type': 'tax',
-                    'account_id': ref('chart1331'),
                 }),
             ]"/>
     </record>
@@ -194,7 +192,6 @@
                 (0,0, {
                     'factor_percent': 100,
                     'repartition_type': 'tax',
-                    'account_id': ref('chart33311'),
                 }),
             ]"/>
         <field name="refund_repartition_line_ids" eval="[(5, 0, 0),
@@ -206,7 +203,6 @@
                 (0,0, {
                     'factor_percent': 100,
                     'repartition_type': 'tax',
-                    'account_id': ref('chart33311'),
                 }),
             ]"/>
     </record>
diff --git a/addons/l10n_vn/migrations/9.0.2.0/post-migrate_tags_on_taxes.py b/addons/l10n_vn/migrations/9.0.2.0/post-migrate_tags_on_taxes.py
deleted file mode 100644
index fa56fd00dfa..00000000000
--- a/addons/l10n_vn/migrations/9.0.2.0/post-migrate_tags_on_taxes.py
+++ /dev/null
@@ -1,6 +0,0 @@
-from openerp.modules.registry import RegistryManager
-
-def migrate(cr, version):
-    registry = RegistryManager.get(cr.dbname)
-    from openerp.addons.account.models.chart_template import migrate_tags_on_taxes
-    migrate_tags_on_taxes(cr, registry)