diff options
| author | Martin Trigaux <mat@odoo.com> | 2019-08-06 15:07:41 +0000 |
|---|---|---|
| committer | Martin Trigaux <mat@odoo.com> | 2019-08-07 13:06:17 +0000 |
| commit | 85ee046b37c7c9a0dc7f052b8258f81774b127de (patch) | |
| tree | 9a7da9025a665ffc52dff9849af4dc9d69e8892d /addons/l10n_multilang | |
| parent | f5cd483216af01001f44a41f7d48f042b9f56ff9 (diff) | |
[IMP] *: use res.lang methods
get_installed and _lang_get_id are both ormcached and correctly check
the context
Retrieving a res.lang from a code is a frequent action that can be
achieved with _lang_get (cf previous commit).
Using _lang_get ensure the active_test in the context is correct and
is not poluted with another context propagation issue.
odoo/odoo#35490 discussion is an example of bad context propagation
closes odoo/odoo#35504
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
Diffstat (limited to 'addons/l10n_multilang')
| -rw-r--r-- | addons/l10n_multilang/models/l10n_multilang.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/addons/l10n_multilang/models/l10n_multilang.py b/addons/l10n_multilang/models/l10n_multilang.py index e307f28d5a3..40433eaed92 100644 --- a/addons/l10n_multilang/models/l10n_multilang.py +++ b/addons/l10n_multilang/models/l10n_multilang.py @@ -118,7 +118,7 @@ class BaseLanguageInstall(models.TransientModel): def lang_install(self): self.ensure_one() - already_installed = self.env['res.lang'].search_count([('code', '=', self.lang)]) + already_installed = self.lang in [code for code, _ in self.env['res.lang'].get_installed()] res = super(BaseLanguageInstall, self).lang_install() if already_installed: # update of translations instead of new installation |