[IMP] account,*: Improve bank statements/payments workflow

- Create journal entries as soon as bank/cash statement lines are created, temporary booked on a suspense account set on the journal.
- Simplify the management of "blue" lines in the reconciliation widget. A "blue" line is now a journal item using a temporary liquidity account (outstanding payment/receipt accounts, set on the journal).
- Adapt and simplify the bank reconciliation report.
- Remove the bank reconciliation threshold date. The reconciliation report will show the not already reconciled journal entries using a liquidity account and the not already reconciled journal entries using a temporary liquidity account. Without accounting, an account.payment will involve directly the liquidity account and then, will be considered as a statement line directly.
- Remove the post_at bank reconciliation feature. The "paid" state will be set on the invoices only if reconciled with a journal entry involving the journal's liquidity account.
    With invoicing, the payment will do that so the "in_payment" state should never be shown up.
    With accounting, only the statement lines have the power to move an invoice to the "paid" state.
- Fix various corner cases about the management of multi-currency in bank statement lines.
- Fix the conversion dates in multi-currency: Since the bank/cash is always used on the statement lines, it will use always the real "bank" date instead of the fictive payment one.
- Ensure the 'reconcile' method will raise an error if the involved moves are not posted.

related enterprise PR odoo/enterprise#7019

closes odoo/odoo#41301

--task: 2092096
Related: odoo/upgrade#1018
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

2 files changed, 5 insertions, 5 deletions

diff --git a/addons/l10n_it_edi/data/invoice_it_template.xml b/addons/l10n_it_edi/data/invoice_it_template.xml
index 12c318cc3aa..7a38ec73b05 100644
--- a/addons/l10n_it_edi/data/invoice_it_template.xml
+++ b/addons/l10n_it_edi/data/invoice_it_template.xml
@@ -46,7 +46,7 @@
 
         <template id="account_invoice_it_FatturaPA_export">
             <t t-set="currency" t-value="record.currency_id or record.company_currency_id"/>
-            <t t-set="bank" t-value="record.invoice_partner_bank_id"/>
+            <t t-set="bank" t-value="record.partner_bank_id"/>
                 <p:FatturaElettronica  t-att-versione="formato_trasmissione" xmlns:ds="http://www.w3.org/2000/09/xmldsig#" xmlns:p="http://ivaservizi.agenziaentrate.gov.it/docs/xsd/fatture/v1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://ivaservizi.agenziaentrate.gov.it/docs/xsd/fatture/v1.2 http://www.fatturapa.gov.it/export/fatturazione/sdi/fatturapa/v1.2/Schema_del_file_xml_FatturaPA_versione_1.2.xsd">
                 <FatturaElettronicaHeader>
                     <DatiTrasmissione>
@@ -168,14 +168,14 @@
                         <t t-set="payments" t-value="record.line_ids.filtered(lambda line: line.account_id.user_type_id.type in ('receivable', 'payable'))"/>
                         <CondizioniPagamento><t t-if="len(payments) == 1">TP02</t><t t-else="">TP01</t></CondizioniPagamento>
                         <DettaglioPagamento>
-                            <t t-set="company_bank_account" t-value="record.invoice_partner_bank_id"/>
+                            <t t-set="company_bank_account" t-value="record.partner_bank_id"/>
                             <ModalitaPagamento t-if="company_bank_account">MP05</ModalitaPagamento>
                             <DataScadenzaPagamento t-esc="format_date(record.invoice_date_due)"/>
                             <ImportoPagamento t-esc="format_numbers_two(record.amount_total)"/>
                             <IstitutoFinanziario t-if="company_bank_account.bank_id" t-esc="company_bank_account.bank_id.name[:80]"/>
                             <IBAN t-if="company_bank_account.acc_type == 'iban'" t-esc="company_bank_account.sanitized_acc_number"/>
                             <BIC t-if="company_bank_account.acc_type == 'bank' and company_bank_account.bank_id.bic" t-esc="company_bank_account.bank_id.bic"/>
-                            <CodicePagamento t-esc="record.invoice_payment_ref[:60]"/>
+                            <CodicePagamento t-esc="record.payment_reference[:60]"/>
                         </DettaglioPagamento>
                     </DatiPagamento>
                     <Allegati t-if="pdf">
diff --git a/addons/l10n_it_edi/models/account_invoice.py b/addons/l10n_it_edi/models/account_invoice.py
index 62bf95a9211..e0354498b6e 100644
--- a/addons/l10n_it_edi/models/account_invoice.py
+++ b/addons/l10n_it_edi/models/account_invoice.py
@@ -384,7 +384,7 @@ class AccountMove(models.Model):
                 # Numbering attributed by the transmitter. <1.1.2>
                 elements = tree.xpath('//ProgressivoInvio')
                 if elements:
-                    invoice_form.invoice_payment_ref = elements[0].text
+                    invoice_form.payment_reference = elements[0].text
 
                 elements = body_tree.xpath('.//DatiGeneraliDocumento//Numero')
                 if elements:
@@ -490,7 +490,7 @@ class AccountMove(models.Model):
                     else:
                         bank = self.env['res.partner.bank'].search([('acc_number', '=', elements[0].text)])
                     if bank:
-                        invoice_form.invoice_partner_bank_id = bank
+                        invoice_form.partner_bank_id = bank
                     else:
                         message_to_log.append("%s<br/>%s" % (
                             _("Bank account not found, useful informations from XML file:"),