diff options
| author | Sébastien Theys <seb@odoo.com> | 2021-01-18 16:49:01 +0000 |
|---|---|---|
| committer | Sébastien Theys <seb@odoo.com> | 2021-01-18 16:59:02 +0000 |
| commit | e995f03a9a55280b1e9173223cdfa619ae164cc3 (patch) | |
| tree | 3aefcd4e4621f11cc971a652d7ed6f01a70765c0 /addons/im_livechat | |
| parent | 20d6efa817a4d839777c81d403bb8770807e784a (diff) | |
[FIX] mail, im_livechat, snailmail: use findFromIdentifyingData
find is O(n) and findFromIdentifyingData is O(1)
task-2440693
closes odoo/odoo#64712
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Diffstat (limited to 'addons/im_livechat')
3 files changed, 12 insertions, 12 deletions
diff --git a/addons/im_livechat/static/src/components/discuss/discuss_tests.js b/addons/im_livechat/static/src/components/discuss/discuss_tests.js index c756f2dff93..4cfd207ff1c 100644 --- a/addons/im_livechat/static/src/components/discuss/discuss_tests.js +++ b/addons/im_livechat/static/src/components/discuss/discuss_tests.js @@ -57,10 +57,10 @@ QUnit.test('livechat in the sidebar: basic rendering', async function (assert) { ); const livechat = groupLivechat.querySelector(` .o_DiscussSidebarItem[data-thread-local-id="${ - this.env.models['mail.thread'].find(thread => - thread.id === 11 && - thread.model === 'mail.channel' - ).localId + this.env.models['mail.thread'].findFromIdentifyingData({ + id: 11, + model: 'mail.channel', + }).localId }"] `); assert.ok( diff --git a/addons/im_livechat/static/src/components/thread_icon/thread_icon_tests.js b/addons/im_livechat/static/src/components/thread_icon/thread_icon_tests.js index a8dceda1484..f37e873ec83 100644 --- a/addons/im_livechat/static/src/components/thread_icon/thread_icon_tests.js +++ b/addons/im_livechat/static/src/components/thread_icon/thread_icon_tests.js @@ -50,10 +50,10 @@ QUnit.test('livechat: public website visitor is typing', async function (assert) members: [this.data.currentPartnerId, this.data.publicPartnerId], }); await this.start(); - const thread = this.env.models['mail.thread'].find(thread => - thread.id === 20 && - thread.model === 'mail.channel' - ); + const thread = this.env.models['mail.thread'].findFromIdentifyingData({ + id: 20, + model: 'mail.channel', + }); await this.createThreadIcon(thread); assert.containsOnce( document.body, diff --git a/addons/im_livechat/static/src/components/thread_textual_typing_status/thread_textual_typing_status_tests.js b/addons/im_livechat/static/src/components/thread_textual_typing_status/thread_textual_typing_status_tests.js index dcc04fe741a..6c05cd74ac1 100644 --- a/addons/im_livechat/static/src/components/thread_textual_typing_status/thread_textual_typing_status_tests.js +++ b/addons/im_livechat/static/src/components/thread_textual_typing_status/thread_textual_typing_status_tests.js @@ -50,10 +50,10 @@ QUnit.test('receive visitor typing status "is typing"', async function (assert) members: [this.data.currentPartnerId, this.data.publicPartnerId], }); await this.start(); - const thread = this.env.models['mail.thread'].find(thread => - thread.id === 20 && - thread.model === 'mail.channel' - ); + const thread = this.env.models['mail.thread'].findFromIdentifyingData({ + id: 20, + model: 'mail.channel', + }); await this.createThreadTextualTypingStatusComponent(thread); assert.strictEqual( |