[IMP] *: replace default_get overrides by default attribute on fields.

Leave the generic management of fields default to the orm as much as
possible.

* Default method is not called unless necessary.
* Default values are correctly post-processed by the orm when necessary.

1 files changed, 5 insertions, 10 deletions

diff --git a/addons/hr_timesheet/wizard/project_task_create_timesheet.py b/addons/hr_timesheet/wizard/project_task_create_timesheet.py
index e55043e982d..b919361822b 100644
--- a/addons/hr_timesheet/wizard/project_task_create_timesheet.py
+++ b/addons/hr_timesheet/wizard/project_task_create_timesheet.py
@@ -11,18 +11,13 @@ class ProjectTaskCreateTimesheet(models.TransientModel):
 
     _sql_constraints = [('time_positive', 'CHECK(time_spent > 0)', 'The timesheet\'s time must be positive' )]
 
-    @api.model
-    def default_get(self, fields):
-        result = super(ProjectTaskCreateTimesheet, self).default_get(fields)
-
-        active_id = self._context.get('active_id')
-        if 'task_id' in fields and active_id:
-            result['task_id'] = active_id
-        return result
-
     time_spent = fields.Float('Time', digits=(16, 2))
     description = fields.Char('Description')
-    task_id = fields.Many2one('project.task', "Task", help="Task for which we are creating a sales order", required=True)
+    task_id = fields.Many2one(
+        'project.task', "Task", required=True,
+        default=lambda self: self.env.context.get('active_id', None),
+        help="Task for which we are creating a sales order",
+    )
 
     def save_timesheet(self):
         values = {