[REF] hr_holidays: Split/Rename models/views according to guidelines

Purpose
=======

Follow the coding guidelines (https://www.odoo.com/documentation/11.0/reference/guidelines.html)

Specification
=============

* each model has now its own .py file
* view files have better names
* reordered the methods for readability
* reimplemented email subtypes

1 files changed, 79 insertions, 16 deletions

diff --git a/addons/hr_holidays/data/hr_holidays_data.xml b/addons/hr_holidays/data/hr_holidays_data.xml
index c6c155a385f..235bd6e036d 100644
--- a/addons/hr_holidays/data/hr_holidays_data.xml
+++ b/addons/hr_holidays/data/hr_holidays_data.xml
@@ -31,65 +31,128 @@
         </record>
 
         <!-- Holidays-related subtypes for messaging / Chatter -->
-        <record id="mt_holidays_confirmed" model="mail.message.subtype">
+        <record id="mt_leave_confirmed" model="mail.message.subtype">
             <field name="name">Confirmed</field>
             <field name="res_model">hr.leave</field>
             <field name="description">Request created and waiting confirmation</field>
         </record>
 
-        <record id="mt_holidays_first_validated" model="mail.message.subtype">
+        <record id="mt_leave_first_validated" model="mail.message.subtype">
             <field name="name">Waiting Second Validation</field>
             <field name="res_model">hr.leave</field>
             <field name="default" eval="False"/>
             <field name="description">Request validated, waiting second validation</field>
         </record>
 
-        <record id="mt_holidays_approved" model="mail.message.subtype">
+        <record id="mt_leave_approved" model="mail.message.subtype">
             <field name="name">Approved</field>
             <field name="res_model">hr.leave</field>
             <field name="description">Request approved</field>
         </record>
 
-        <record id="mt_holidays_refused" model="mail.message.subtype">
+        <record id="mt_leave_refused" model="mail.message.subtype">
             <field name="name">Refused</field>
             <field name="res_model">hr.leave</field>
             <field name="default" eval="False"/>
             <field name="description">Request refused</field>
         </record>
 
+        <!-- Allocation-related subtypes for messaging / Chatter -->
+        <record id="mt_leave_allocation_confirmed" model="mail.message.subtype">
+            <field name="name">Confirmed</field>
+            <field name="res_model">hr.leave.allocation</field>
+            <field name="description">Request created and waiting confirmation</field>
+        </record>
+
+        <record id="mt_leave_allocation_first_validated" model="mail.message.subtype">
+            <field name="name">Waiting Second Validation</field>
+            <field name="res_model">hr.leave.allocation</field>
+            <field name="default" eval="False"/>
+            <field name="description">Request validated, waiting second validation</field>
+        </record>
+
+        <record id="mt_leave_allocation_approved" model="mail.message.subtype">
+            <field name="name">Approved</field>
+            <field name="res_model">hr.leave.allocation</field>
+            <field name="description">Request approved</field>
+        </record>
+
+        <record id="mt_leave_allocation_refused" model="mail.message.subtype">
+            <field name="name">Refused</field>
+            <field name="res_model">hr.leave.allocation</field>
+            <field name="default" eval="False"/>
+            <field name="description">Request refused</field>
+        </record>
+
         <!-- Department related subtypes for messaging / Chatter -->
-        <record id="mt_department_holidays_confirmed" model="mail.message.subtype">
-            <field name="name">Leaves/Allocations Confirmed</field>
+        <record id="mt_department_leave_confirmed" model="mail.message.subtype">
+            <field name="name">Leaves Confirmed</field>
+            <field name="res_model">hr.department</field>
+            <field name="default" eval="True"/>
+            <field name="parent_id" eval="ref('mt_leave_confirmed')"/>
+            <field name="relation_field">department_id</field>
+            <field name="sequence" eval="6"/>
+        </record>
+
+        <record id="mt_department_leave_first_validated" model="mail.message.subtype">
+            <field name="name">Leaves First Approval</field>
+            <field name="res_model">hr.department</field>
+            <field name="default" eval="False"/>
+            <field name="parent_id" eval="ref('mt_leave_first_validated')"/>
+            <field name="relation_field">department_id</field>
+            <field name="sequence" eval="7"/>
+        </record>
+
+        <record id="mt_department_leave_approved" model="mail.message.subtype">
+            <field name="name">Leaves Approved</field>
+            <field name="res_model">hr.department</field>
+            <field name="default" eval="False"/>
+            <field name="parent_id" eval="ref('mt_leave_approved')"/>
+            <field name="relation_field">department_id</field>
+            <field name="sequence" eval="8"/>
+        </record>
+
+        <record id="mt_department_leave_refused" model="mail.message.subtype">
+            <field name="name">Leaves Refused</field>
+            <field name="res_model">hr.department</field>
+            <field name="default" eval="False"/>
+            <field name="parent_id" eval="ref('mt_leave_refused')"/>
+            <field name="relation_field">department_id</field>
+            <field name="sequence" eval="9"/>
+        </record>
+
+        <record id="mt_department_leave_allocation_confirmed" model="mail.message.subtype">
+            <field name="name">Allocations Confirmed</field>
             <field name="res_model">hr.department</field>
             <field name="default" eval="True"/>
-            <field name="parent_id" eval="ref('mt_holidays_confirmed')"/>
+            <field name="parent_id" eval="ref('mt_leave_allocation_confirmed')"/>
             <field name="relation_field">department_id</field>
             <field name="sequence" eval="6"/>
         </record>
 
-        <record id="mt_department_holidays_first_validated" model="mail.message.subtype">
-            <field name="name">Leaves/Allocations First Approval</field>
+        <record id="mt_department_leave_allocation_first_validated" model="mail.message.subtype">
+            <field name="name">Allocations First Approval</field>
             <field name="res_model">hr.department</field>
             <field name="default" eval="False"/>
-            <field name="parent_id" eval="ref('mt_holidays_first_validated')"/>
+            <field name="parent_id" eval="ref('mt_leave_allocation_first_validated')"/>
             <field name="relation_field">department_id</field>
             <field name="sequence" eval="7"/>
         </record>
 
-        <record id="mt_department_holidays_approved" model="mail.message.subtype">
-            <field name="name">Leaves/Allocation Approved</field>
+        <record id="mt_department_leave_allocation_approved" model="mail.message.subtype">
+            <field name="name">Allocation Approved</field>
             <field name="res_model">hr.department</field>
             <field name="default" eval="False"/>
-            <field name="parent_id" eval="ref('mt_holidays_approved')"/>
+            <field name="parent_id" eval="ref('mt_leave_allocation_approved')"/>
             <field name="relation_field">department_id</field>
             <field name="sequence" eval="8"/>
         </record>
 
-        <record id="mt_department_holidays_refused" model="mail.message.subtype">
-            <field name="name">Leaves/Allocation Refused</field>
+        <record id="mt_department_leave_allocation_refused" model="mail.message.subtype">
+            <field name="name">Allocation Refused</field>
             <field name="res_model">hr.department</field>
             <field name="default" eval="False"/>
-            <field name="parent_id" eval="ref('mt_holidays_refused')"/>
+            <field name="parent_id" eval="ref('mt_leave_allocation_refused')"/>
             <field name="relation_field">department_id</field>
             <field name="sequence" eval="9"/>
         </record>