diff options
| author | Xavier Morel <xmo@odoo.com> | 2020-02-05 10:34:51 +0000 |
|---|---|---|
| committer | Xavier Morel <xmo@odoo.com> | 2020-02-12 09:32:17 +0000 |
| commit | e95ccf0908c263f6cf23c91c477a8e252e936ff1 (patch) | |
| tree | f5e7b10ebf7726a9f17598f0407d0a8cb14298c3 /addons/hr_attendance/views | |
| parent | 968638aa1a158d24789ba6f0374436c74f807f2e (diff) | |
[FIX] *: domains should not have as many binary operator as there are terms
* modify client-side domain normalisation to error if the domain is
invalid (not enough terms / segments for the number of operators)
* add better error reporting to attrs / modifiers parsing
* add a few layered error augmentation to provide clearer context
e.g. "error: invalid domain <thing>" is helpful but "error while
parsing modifiers for field foo: modifier invisible: invalid domain
<thing>" is much more helpful
* rework _evalModifiers to deduplicate it in order to more easily
implement this contextual augmentation
* test that improper domains are properly found improper
* fix a bunch of incorrect attrs domains
* also removed an apparently undefined (& unused) "options" argument
to a _applyModifiers call
closes odoo/odoo#44642
Related: odoo/enterprise#8175
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
Diffstat (limited to 'addons/hr_attendance/views')
| -rw-r--r-- | addons/hr_attendance/views/hr_employee_view.xml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/addons/hr_attendance/views/hr_employee_view.xml b/addons/hr_attendance/views/hr_employee_view.xml index 665a8ed0a98..abfc22d1493 100644 --- a/addons/hr_attendance/views/hr_employee_view.xml +++ b/addons/hr_attendance/views/hr_employee_view.xml @@ -63,7 +63,7 @@ <field name="arch" type="xml"> <xpath expr="//button[@id='hr_presence_button']" position="attributes"> <attribute name="attrs"> - {'invisible': ['|', '|', ('hr_presence_state', '=', 'absent'), ('attendance_state', '=', 'checked_in')]} + {'invisible': ['|', ('hr_presence_state', '=', 'absent'), ('attendance_state', '=', 'checked_in')]} </attribute> </xpath> <xpath expr="//div[@name='button_box']" position="inside"> |