diff options
| author | alt-odoo <alt@odoo.com> | 2019-11-22 13:23:01 +0000 |
|---|---|---|
| committer | fw-bot <otis@odoo.com> | 2019-11-22 16:57:21 +0000 |
| commit | ab60da1269ecf65a46051babd2a33cdab4a8908b (patch) | |
| tree | f5adfd41f534eb4ed03fc6063a2f9b789eaafafe /addons/gamification | |
| parent | c8e6362e605479e4e432d8cad32ad91fb44015c2 (diff) | |
[FIX] gamification: prevent division by zero in percentage completeness computation
We are initializing over the limit to make sure we will compute it at least once.
If the target goal is set to 0, we are facing a division by zero error when
displaying the gamification goal just after initialization.
closes odoo/odoo#40735
X-original-commit: 24546e7c4cac61efea8d3f9e558518a55ef9acd2
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Diffstat (limited to 'addons/gamification')
| -rw-r--r-- | addons/gamification/models/challenge.py | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/addons/gamification/models/challenge.py b/addons/gamification/models/challenge.py index ad932dddc31..868e46d1fdf 100644 --- a/addons/gamification/models/challenge.py +++ b/addons/gamification/models/challenge.py @@ -377,11 +377,11 @@ class Challenge(models.Model): if end_date: values['end_date'] = end_date - # the goal is initialised over the limit to make sure we will compute it at least once - if line.condition == 'higher': - values['current'] = min(line.target_goal - 1, 0) - else: - values['current'] = max(line.target_goal + 1, 0) + # the goal is initialised over the limit to make sure we will compute it at least once + if line.condition == 'higher': + values['current'] = min(line.target_goal - 1, 0) + else: + values['current'] = max(line.target_goal + 1, 0) if challenge.remind_update_delay: values['remind_update_delay'] = challenge.remind_update_delay |