diff options
| author | mreficent <miquel.raich@eficent.com> | 2020-02-19 12:42:23 +0000 |
|---|---|---|
| committer | Martin Trigaux <mat@odoo.com> | 2020-02-20 14:58:33 +0000 |
| commit | 3dffce34bf80c2a8d8682ef986d6daafa5bb0b7f (patch) | |
| tree | 3ec174f7aa3d672d07635d4f54401ff3d7fa3725 /addons/gamification/models | |
| parent | 62c9227fdaac43329e48cd9446b40eee60dfeb1c (diff) | |
[IMP] fields: log warning for ignored selection
When a field is related, defining a selection or selection_add will
have no effect and the paramater is ignored.
Log a warning and fix all fields badly definied
Closes odoo/odoo#45716
closes odoo/odoo#45832
Related: odoo/enterprise#8613
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
Diffstat (limited to 'addons/gamification/models')
| -rw-r--r-- | addons/gamification/models/badge.py | 1 | ||||
| -rw-r--r-- | addons/gamification/models/challenge.py | 2 | ||||
| -rw-r--r-- | addons/gamification/models/goal.py | 4 |
3 files changed, 3 insertions, 4 deletions
diff --git a/addons/gamification/models/badge.py b/addons/gamification/models/badge.py index 7bfdd074644..c202bde3374 100644 --- a/addons/gamification/models/badge.py +++ b/addons/gamification/models/badge.py @@ -24,7 +24,6 @@ class BadgeUser(models.Model): comment = fields.Text('Comment') badge_name = fields.Char(related='badge_id.name', string="Badge Name", readonly=False) level = fields.Selection( - [('bronze', 'Bronze'), ('silver', 'Silver'), ('gold', 'Gold')], string='Badge Level', related="badge_id.level", store=True, readonly=True) def _send_badge(self): diff --git a/addons/gamification/models/challenge.py b/addons/gamification/models/challenge.py index b2fb80e7389..19aa131270e 100644 --- a/addons/gamification/models/challenge.py +++ b/addons/gamification/models/challenge.py @@ -790,7 +790,7 @@ class ChallengeLine(models.Model): target_goal = fields.Float('Target Value to Reach', required=True) name = fields.Char("Name", related='definition_id.name', readonly=False) - condition = fields.Selection("Condition", related='definition_id.condition', readonly=True) + condition = fields.Selection(string="Condition", related='definition_id.condition', readonly=True) definition_suffix = fields.Char("Unit", related='definition_id.suffix', readonly=True) definition_monetary = fields.Boolean("Monetary", related='definition_id.monetary', readonly=True) definition_full_suffix = fields.Char("Suffix", related='definition_id.full_suffix', readonly=True) diff --git a/addons/gamification/models/goal.py b/addons/gamification/models/goal.py index 51fa991d6d1..d6dd9e5a919 100644 --- a/addons/gamification/models/goal.py +++ b/addons/gamification/models/goal.py @@ -179,9 +179,9 @@ class Goal(models.Model): "case of non-manual goal or goal not linked to a challenge.") definition_description = fields.Text("Definition Description", related='definition_id.description', readonly=True) - definition_condition = fields.Selection("Definition Condition", related='definition_id.condition', readonly=True) + definition_condition = fields.Selection(string="Definition Condition", related='definition_id.condition', readonly=True) definition_suffix = fields.Char("Suffix", related='definition_id.full_suffix', readonly=True) - definition_display = fields.Selection("Display Mode", related='definition_id.display_mode', readonly=True) + definition_display = fields.Selection(string="Display Mode", related='definition_id.display_mode', readonly=True) @api.depends('current', 'target_goal', 'definition_id.condition') def _get_completion(self): |