[FIX] gamification: adapt _get_next_rank method to always return a recordset

The return type of the _get_next_rank method on the 'res.users' model was inconsistent.
It sometimes returned a recordset, sometimes False.

This commit adapts the method to always return a recordset (which is empty for the previously
'False' case).

This is a preliminary work for the level up animation on website_slides task.

PR #39870
Task#2032649

1 files changed, 7 insertions, 1 deletions

diff --git a/addons/gamification/models/res_users.py b/addons/gamification/models/res_users.py
index bcfd815e4d5..f2806ee8531 100644
--- a/addons/gamification/models/res_users.py
+++ b/addons/gamification/models/res_users.py
@@ -283,7 +283,13 @@ WHERE sub.user_id IN %%s""" % {
         default value in related views.
 
         TDE FIXME in post-12.4: make next_rank_id a non-stored computed field correctly computed """
-        return self.next_rank_id or (not self.rank_id and self.env['gamification.karma.rank'].search([], order="karma_min ASC", limit=1))
+
+        if self.next_rank_id:
+            return self.next_rank_id
+        elif not self.rank_id:
+            return self.env['gamification.karma.rank'].search([], order="karma_min ASC", limit=1)
+        else:
+            return self.env['gamification.karma.rank']
 
     def get_gamification_redirection_data(self):
         """