[IMP] base,*: Reorganize access rights groups

Purpose
=======

Access group terminology is missleading. Yous have to be manager to administrate
an application. This task consists to rename groups to be understandable for everyone.

Groups should be reorganised on the users form to be more explicit.

Specification
=============

1/ Rename 'Manager' to 'Administrator' in users groups.
2/ Define a hierarchy on access groups by using the category_id in the manifests
   A category 'Operations/Project' will create a category Project with a parent
   category 'Operations', and something smart is already developed (in modules/db.py)
   to avoid duplicating categories.
3/ Add a group in expenses to be able to approve expenses reports for my team.
4/ Add a group in timesheets to be able to approve timesheets for my team.
5/ Remove partially the useless crap in ir_module_category_data.xml
6/ Sort access rights groups on users form according to its parent category

closes odoo/odoo#29362

Signed-off-by: "Yannick Tivisse (yti)" <yti@odoo.com>

2 files changed, 10 insertions, 10 deletions

diff --git a/addons/fleet/__manifest__.py b/addons/fleet/__manifest__.py
index 0a874e3bda9..a61d2508b9d 100644
--- a/addons/fleet/__manifest__.py
+++ b/addons/fleet/__manifest__.py
@@ -4,7 +4,7 @@
     'name' : 'Fleet',
     'version' : '0.1',
     'sequence': 165,
-    'category': 'Human Resources',
+    'category': 'Human Resources/Fleet',
     'website' : 'https://www.odoo.com/page/fleet',
     'summary' : 'Manage your fleet and track car costs',
     'description' : """
diff --git a/addons/fleet/security/fleet_security.xml b/addons/fleet/security/fleet_security.xml
index 29777a1ab47..60580ef46ee 100644
--- a/addons/fleet/security/fleet_security.xml
+++ b/addons/fleet/security/fleet_security.xml
@@ -6,13 +6,13 @@
         </record>
         <record id="fleet_group_user" model="res.groups">
             <field name="name">User</field>
-            <field name="category_id" ref="module_fleet_category"/>
+            <field name="category_id" ref="base.module_category_human_resources_fleet"/>
             <field name="implied_ids" eval="[(4, ref('base.group_user'))]"/>
         </record>
         <record id="fleet_group_manager" model="res.groups">
-            <field name="name">Manager</field>
+            <field name="name">Administrator</field>
             <field name="implied_ids" eval="[(4, ref('fleet_group_user'))]"/>
-            <field name="category_id" ref="module_fleet_category"/>
+            <field name="category_id" ref="base.module_category_human_resources_fleet"/>
             <field name="users" eval="[(4, ref('base.user_root')), (4, ref('base.user_admin'))]"/>
         </record>
 
@@ -81,32 +81,32 @@
             <field name="domain_force">[('driver_id','=',user.partner_id.id)]</field>
         </record>
         <record id="fleet_rule_contract_visibility_manager" model="ir.rule">
-            <field name="name">Manager has all rights on vehicle's contracts</field>
+            <field name="name">Administrator has all rights on vehicle's contracts</field>
             <field name="model_id" ref="model_fleet_vehicle_log_contract"/>
             <field name="groups" eval="[(4, ref('fleet_group_manager'))]"/>
         </record>
         <record id="fleet_rule_cost_visibility_manager" model="ir.rule">
-            <field name="name">Manager has all rights on vehicle's costs</field>
+            <field name="name">Administrator has all rights on vehicle's costs</field>
             <field name="model_id" ref="model_fleet_vehicle_cost"/>
             <field name="groups" eval="[(4, ref('fleet_group_manager'))]"/>
         </record>
         <record id="fleet_rule_service_visibility_manager" model="ir.rule">
-            <field name="name">Manager has all rights on vehicle's services</field>
+            <field name="name">Administrator has all rights on vehicle's services</field>
             <field name="model_id" ref="model_fleet_vehicle_log_services"/>
             <field name="groups" eval="[(4, ref('fleet_group_manager'))]"/>
         </record>
         <record id="fleet_rule_odometer_visibility_manager" model="ir.rule">
-            <field name="name">Manager has all rights on vehicle's vehicle's odometer</field>
+            <field name="name">Administrator has all rights on vehicle's vehicle's odometer</field>
             <field name="model_id" ref="model_fleet_vehicle_odometer"/>
             <field name="groups" eval="[(4, ref('fleet_group_manager'))]"/>
         </record>
         <record id="fleet_rule_fuel_log_visibility_manager" model="ir.rule">
-            <field name="name">Manager has all rights on vehicle's fuel log</field>
+            <field name="name">Administrator has all rights on vehicle's fuel log</field>
             <field name="model_id" ref="model_fleet_vehicle_log_fuel"/>
             <field name="groups" eval="[(4, ref('fleet_group_manager'))]"/>
         </record>
         <record id="fleet_rule_vehicle_visibility_manager" model="ir.rule">
-            <field name="name">Manager has all rights on vehicle</field>
+            <field name="name">Administrator has all rights on vehicle</field>
             <field name="model_id" ref="model_fleet_vehicle"/>
             <field name="groups" eval="[(4, ref('fleet_group_manager'))]"/>
         </record>