[IMP] event: improve test class and data to help reusing them

PURPOSE

Allow the user to schedule SMS communication on events

SPECIFICATIONS

In order to add tests this commit performs a quick cleaning of event common
class to speedup and prepare new tests.

Containing
  * move data creation in class and use savepoint;
  * move registration creation in its own method to allow calling it if
    necessary;
  * clean some unnecessary variables.

LINKS

Task 1922187
Part of PR #34705

1 files changed, 5 insertions, 7 deletions

diff --git a/addons/event/tests/test_mail_schedule.py b/addons/event/tests/test_mail_schedule.py
index 1210c33f2ac..7dcc446dc9c 100644
--- a/addons/event/tests/test_mail_schedule.py
+++ b/addons/event/tests/test_mail_schedule.py
@@ -17,7 +17,7 @@ class TestMailSchedule(TestEventCommon):
         event_date_begin = now + relativedelta(days=1)
         event_date_end = now + relativedelta(days=3)
 
-        test_event = self.Event.with_user(self.user_eventmanager).create({
+        test_event = self.env['event.event'].with_user(self.user_eventmanager).create({
             'name': 'TestEventMail',
             'auto_confirm': True,
             'date_begin': event_date_begin,
@@ -37,19 +37,19 @@ class TestMailSchedule(TestEventCommon):
         })
 
         # create some registrations
-        self.Registration.with_user(self.user_eventuser).create({
+        self.env['event.registration'].with_user(self.user_eventuser).create({
             'event_id': test_event.id,
             'name': 'Reg0',
             'email': 'reg0@example.com',
         })
-        self.Registration.with_user(self.user_eventuser).create({
+        self.env['event.registration'].with_user(self.user_eventuser).create({
             'event_id': test_event.id,
             'name': 'Reg1',
             'email': 'reg1@example.com',
         })
 
         # check subscription scheduler
-        schedulers = self.EventMail.search([('event_id', '=', test_event.id), ('interval_type', '=', 'after_sub')])
+        schedulers = self.env['event.mail'].search([('event_id', '=', test_event.id), ('interval_type', '=', 'after_sub')])
         self.assertEqual(len(schedulers), 1, 'event: wrong scheduler creation')
         self.assertEqual(schedulers[0].scheduled_date, test_event.create_date, 'event: incorrect scheduled date for checking controller')
 
@@ -63,7 +63,7 @@ class TestMailSchedule(TestEventCommon):
             self.assertTrue(registration.mail_sent, 'event: wrongly confirmed mailing on registration')
 
         # check before event scheduler
-        schedulers = self.EventMail.search([('event_id', '=', test_event.id), ('interval_type', '=', 'before_event')])
+        schedulers = self.env['event.mail'].search([('event_id', '=', test_event.id), ('interval_type', '=', 'before_event')])
         self.assertEqual(len(schedulers), 1, 'event: wrong scheduler creation')
         self.assertEqual(schedulers[0].scheduled_date, event_date_begin + relativedelta(days=-1), 'event: incorrect scheduled date')
 
@@ -75,5 +75,3 @@ class TestMailSchedule(TestEventCommon):
 
         mails = self.env['mail.mail'].search([('subject', 'ilike', 'TestEventMail'), ('date', '>=', now)], order='date DESC', limit=3)
         self.assertEqual(len(mails), 3, 'event: wrong number of reminders in outgoing mail queue')
-
-