summaryrefslogtreecommitdiff
path: root/addons/event/tests/test_event_mail_schedule.py
diff options
context:
space:
mode:
authorThibault Delavallée <tde@odoo.com>2021-03-19 13:30:15 +0000
committerThibault Delavallée <tde@odoo.com>2021-03-19 16:36:25 +0000
commit353bc5de9fafbc1527c382614e02438ee799c8a4 (patch)
treede28f9344bf2ae2dda0111c8ce16ba293a36a1a7 /addons/event/tests/test_event_mail_schedule.py
parent73d09268922a7d242af85e36a3d81ed25ab4ca33 (diff)
[FIX] event: respect scheduled date when calling mail schedulers execute
In this commit we ensure calling ``execute`` method on communication schedulers do not send emails or SMS if their scheduled date is still not achieved. Currently only the cron method does it (see ``run``). It is now safe to call ``execute`` directly on event communication schedulers. Related to Task ID-2414658 COM PR odoo/odoo#68158
Diffstat (limited to 'addons/event/tests/test_event_mail_schedule.py')
-rw-r--r--addons/event/tests/test_event_mail_schedule.py15
1 files changed, 7 insertions, 8 deletions
diff --git a/addons/event/tests/test_event_mail_schedule.py b/addons/event/tests/test_event_mail_schedule.py
index 7ec60492b24..896a5873205 100644
--- a/addons/event/tests/test_event_mail_schedule.py
+++ b/addons/event/tests/test_event_mail_schedule.py
@@ -152,14 +152,13 @@ class TestMailSchedule(TestEventCommon, MockEmail):
self.assertFalse(event_prev_scheduler.done)
# execute event reminder scheduler explicitly, before scheduled date -> should not do anything
- # FIXME: execute does not respect scheduled date
- # now_start = event_date_begin + relativedelta(hours=-25)
- # with freeze_time(now_start), self.mock_mail_gateway():
- # event_prev_scheduler.execute()
-
- # self.assertFalse(event_prev_scheduler.mail_sent)
- # self.assertFalse(event_prev_scheduler.done)
- # self.assertEqual(len(self._new_mails, 0))
+ now_start = event_date_begin + relativedelta(hours=-25)
+ with freeze_time(now_start), self.mock_mail_gateway():
+ event_prev_scheduler.execute()
+
+ self.assertFalse(event_prev_scheduler.mail_sent)
+ self.assertFalse(event_prev_scheduler.done)
+ self.assertEqual(len(self._new_mails), 0)
# execute cron to run schedulers
now_start = event_date_begin + relativedelta(hours=-23)