diff options
| author | Lavish Chhatwani <lch@odoo.com> | 2020-06-22 13:36:22 +0000 |
|---|---|---|
| committer | Thibault Delavallée <tde@odoo.com> | 2020-07-27 08:03:19 +0000 |
| commit | 29c39dab3be9db1fc6b414e136306c0227feff32 (patch) | |
| tree | cd7eee7d29d632d69ddd7aeeaf77058777cf342d /addons/crm/models | |
| parent | 89d5628c9d4b308c9f6982aaa96612d7c48e3690 (diff) | |
[FIX] crm : prevent a false positive warning ribbon for phone on lead
In the lead, we compute the phone number to make it formatted to match
with the international phone number format.
Before this commit, this formatted number was used for comparison with
partner's phone (which is not formatted), and so, even if both the
numbers are same, the warning ribbon appears due to different formats
which is not correct behavior.
This commit fixes the issue by comparing both the formatted number to
remove the false positive warning ribbon and thus making sure that it
appears only when there actually is a difference between lead's phone
and the phone number set on partner.
Task Id-2274752
closes odoo/odoo#54942
X-original-commit: d29862c1de6208f7fdb7c8104afe0d35241d130b
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Diffstat (limited to 'addons/crm/models')
| -rw-r--r-- | addons/crm/models/crm_lead.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/addons/crm/models/crm_lead.py b/addons/crm/models/crm_lead.py index d7d352b4efb..0f04fa0ff0e 100644 --- a/addons/crm/models/crm_lead.py +++ b/addons/crm/models/crm_lead.py @@ -367,8 +367,9 @@ class Lead(models.Model): @api.depends('email_from', 'phone', 'partner_id') def _compute_ribbon_message(self): for lead in self: + partner_formatted_phone = lead.partner_id.phone and self.phone_format(lead.partner_id.phone) will_write_email = lead.partner_id and lead.email_from != lead.partner_id.email - will_write_phone = lead.partner_id and lead.phone != lead.partner_id.phone + will_write_phone = lead.partner_id and lead.phone != partner_formatted_phone if will_write_email and will_write_phone: lead.ribbon_message = _('By saving this change, the customer email and phone number will also be updated.') |