[IMP] *: use `ref=` instead of `eval="ref('` in xml field tags.

* Code cleanup
* Avoid a safe evaluation of the field value when loading those records.

closes odoo/odoo#44883

Related: odoo/enterprise#8283
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

2 files changed, 11 insertions, 11 deletions

diff --git a/addons/crm/data/crm_lead_data.xml b/addons/crm/data/crm_lead_data.xml
index 2ef4a9fea08..52f7575aa79 100644
--- a/addons/crm/data/crm_lead_data.xml
+++ b/addons/crm/data/crm_lead_data.xml
@@ -40,21 +40,21 @@
             <field name="sequence">10</field>
             <field name="res_model">crm.team</field>
             <field name="default" eval="True"/>
-            <field name="parent_id" eval="ref('mt_lead_create')"/>
+            <field name="parent_id" ref="mt_lead_create"/>
             <field name="relation_field">team_id</field>
         </record>
         <record id="mt_salesteam_lead_stage" model="mail.message.subtype">
             <field name="name">Opportunity Stage Changed</field>
             <field name="sequence">11</field>
             <field name="res_model">crm.team</field>
-            <field name="parent_id" eval="ref('mt_lead_stage')"/>
+            <field name="parent_id" ref="mt_lead_stage"/>
             <field name="relation_field">team_id</field>
         </record>
         <record id="mt_salesteam_lead_won" model="mail.message.subtype">
             <field name="name">Opportunity Won</field>
             <field name="sequence">12</field>
             <field name="res_model">crm.team</field>
-            <field name="parent_id" eval="ref('mt_lead_won')"/>
+            <field name="parent_id" ref="mt_lead_won"/>
             <field name="relation_field">team_id</field>
         </record>
         <record id="mt_salesteam_lead_lost" model="mail.message.subtype">
@@ -62,7 +62,7 @@
             <field name="sequence">13</field>
             <field name="res_model">crm.team</field>
             <field name="default" eval="False"/>
-            <field name="parent_id" eval="ref('mt_lead_lost')"/>
+            <field name="parent_id" ref="mt_lead_lost"/>
             <field name="relation_field">team_id</field>
         </record>
         <record id="mt_salesteam_lead_restored" model="mail.message.subtype">
@@ -70,7 +70,7 @@
             <field name="sequence">14</field>
             <field name="res_model">crm.team</field>
             <field name="default" eval="False"/>
-            <field name="parent_id" eval="ref('mt_lead_restored')"/>
+            <field name="parent_id" ref="mt_lead_restored"/>
             <field name="relation_field">team_id</field>
         </record>
 
diff --git a/addons/crm/data/crm_lead_prediction_data.xml b/addons/crm/data/crm_lead_prediction_data.xml
index 1a1cbc3675f..e37c6c36e7c 100644
--- a/addons/crm/data/crm_lead_prediction_data.xml
+++ b/addons/crm/data/crm_lead_prediction_data.xml
@@ -3,22 +3,22 @@
     <data noupdate="1">
         <!-- Lead scoring frequency fields -->
         <record id="frequency_field_state_id" model="crm.lead.scoring.frequency.field">
-            <field name="field_id" eval="ref('crm.field_crm_lead__state_id')"/>
+            <field name="field_id" ref="crm.field_crm_lead__state_id"/>
         </record>
         <record id="frequency_field_country_id" model="crm.lead.scoring.frequency.field">
-            <field name="field_id" eval="ref('crm.field_crm_lead__country_id')"/>
+            <field name="field_id" ref="crm.field_crm_lead__country_id"/>
         </record>
         <record id="frequency_field_phone_state" model="crm.lead.scoring.frequency.field">
-            <field name="field_id" eval="ref('crm.field_crm_lead__phone_state')"/>
+            <field name="field_id" ref="crm.field_crm_lead__phone_state"/>
         </record>
         <record id="frequency_field_email_state" model="crm.lead.scoring.frequency.field">
-            <field name="field_id" eval="ref('crm.field_crm_lead__email_state')"/>
+            <field name="field_id" ref="crm.field_crm_lead__email_state"/>
         </record>
         <record id="frequency_field_source_id" model="crm.lead.scoring.frequency.field">
-            <field name="field_id" eval="ref('crm.field_crm_lead__source_id')"/>
+            <field name="field_id" ref="crm.field_crm_lead__source_id"/>
         </record>
         <record id="frequency_field_lang_id" model="crm.lead.scoring.frequency.field">
-            <field name="field_id" eval="ref('crm.field_crm_lead__lang_id')"/>
+            <field name="field_id" ref="crm.field_crm_lead__lang_id"/>
         </record>
         <record id="crm_pls_fields_param" model="ir.config_parameter">
             <field name="key">crm.pls_fields</field>