[IMP] crm: lint data and menu entries

PURPOSE

Prepare enhancements of sales team membership.

SPECIFICATIONS

Lint crm data and demo, notably about sales team and file organization.
Also move crm menu entries declaration in a single file and remove some
menu entries not imported anymore.

LINKS

Task ID 2086889 (sales team enhancements)
Task ID 2234698 (preparation lint)
Community PR odoo/odoo#49520

5 files changed, 34 insertions, 40 deletions

diff --git a/addons/crm/data/crm_data.xml b/addons/crm/data/crm_data.xml
deleted file mode 100644
index 0ee888fea90..00000000000
--- a/addons/crm/data/crm_data.xml
+++ /dev/null
@@ -1,35 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<odoo>
-    <data noupdate="1">
-        <record id="sales_team.salesteam_website_sales" model="crm.team" forcecreate="False">
-            <field name="use_opportunities" eval="False"/>
-        </record>
-
-        <record id="sales_team.pos_sales_team" model="crm.team" forcecreate="False">
-            <field name="use_opportunities" eval="False"/>
-        </record>
-
-        <record id="sales_team.ebay_sales_team" model="crm.team" forcecreate="False">
-            <field name="use_opportunities" eval="False"/>
-        </record>
-
-        <!--default alias for leads-->
-        <record id="mail_alias_lead_info" model="mail.alias">
-            <field name="alias_name"></field>
-            <field name="alias_model_id" ref="model_crm_lead"/>
-            <field name="alias_user_id" ref="base.user_admin"/>
-            <field name="alias_parent_model_id" ref="model_crm_team"/>
-        </record>
-
-        <!-- opportunities' lost causes -->
-        <record id="lost_reason_1" model="crm.lost.reason">
-            <field name="name">Too expensive</field>
-        </record>
-        <record id="lost_reason_2" model="crm.lost.reason">
-            <field name="name">We don't have people/skills</field>
-        </record>
-        <record id="lost_reason_3" model="crm.lost.reason">
-            <field name="name">Not enough stock</field>
-        </record>
-    </data>
-</odoo>
diff --git a/addons/crm/data/crm_lost_reason_data.xml b/addons/crm/data/crm_lost_reason_data.xml
new file mode 100644
index 00000000000..a13a1d77b34
--- /dev/null
+++ b/addons/crm/data/crm_lost_reason_data.xml
@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="utf-8"?>
+<odoo><data noupdate="1">
+    <!-- opportunities' lost causes -->
+    <record id="lost_reason_1" model="crm.lost.reason">
+        <field name="name">Too expensive</field>
+    </record>
+    <record id="lost_reason_2" model="crm.lost.reason">
+        <field name="name">We don't have people/skills</field>
+    </record>
+    <record id="lost_reason_3" model="crm.lost.reason">
+        <field name="name">Not enough stock</field>
+    </record>
+</data></odoo>
diff --git a/addons/crm/data/crm_team_data.xml b/addons/crm/data/crm_team_data.xml
new file mode 100644
index 00000000000..016777ce78f
--- /dev/null
+++ b/addons/crm/data/crm_team_data.xml
@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="utf-8"?>
+<odoo><data noupdate="1">
+    <record id="sales_team.salesteam_website_sales" model="crm.team" forcecreate="False">
+        <field name="use_opportunities" eval="False"/>
+    </record>
+
+    <record id="sales_team.pos_sales_team" model="crm.team" forcecreate="False">
+        <field name="use_opportunities" eval="False"/>
+    </record>
+
+    <record id="sales_team.ebay_sales_team" model="crm.team" forcecreate="False">
+        <field name="use_opportunities" eval="False"/>
+    </record>
+</data></odoo>
diff --git a/addons/crm/data/crm_demo.xml b/addons/crm/data/crm_team_demo.xml
index f5f0ed06bed..f04c60baa30 100644
--- a/addons/crm/data/crm_demo.xml
+++ b/addons/crm/data/crm_team_demo.xml
@@ -1,14 +1,9 @@
 <?xml version="1.0" encoding="utf-8"?>
 <odoo>
     <data noupdate="1">
-        <record id="base.user_demo" model="res.users">
-            <field name="groups_id" eval="[(4,ref('sales_team.group_sale_salesman'))]"/>
-        </record>
-
         <record id="sales_team.team_sales_department" model="crm.team" forcecreate="False">
             <field name="alias_name">sales</field>
             <field name="alias_user_id" ref="base.user_admin"/>
-            <field name="company_id" eval="False"/>
         </record>
 
         <record id="sales_team.crm_team_1" model="crm.team">
diff --git a/addons/crm/data/crm_lead_data.xml b/addons/crm/data/mail_data.xml
index 52f7575aa79..28253e529b5 100644
--- a/addons/crm/data/crm_lead_data.xml
+++ b/addons/crm/data/mail_data.xml
@@ -1,6 +1,13 @@
 <?xml version="1.0"?>
 <odoo>
     <data noupdate="1">
+        <!--default alias for leads-->
+        <record id="mail_alias_lead_info" model="mail.alias">
+            <field name="alias_name"></field>
+            <field name="alias_model_id" ref="model_crm_lead"/>
+            <field name="alias_user_id" ref="base.user_admin"/>
+            <field name="alias_parent_model_id" ref="model_crm_team"/>
+        </record>
 
         <!-- CRM-related subtypes for messaging / Chatter -->
         <record id="mt_lead_create" model="mail.message.subtype">