summaryrefslogtreecommitdiff
path: root/addons/base_vat/models
diff options
context:
space:
mode:
authoroco-odoo <oco@odoo.com>2021-03-23 15:29:47 +0000
committeroco-odoo <oco@odoo.com>2021-04-02 09:45:24 +0000
commit72b7fb15db4df1a3336bc6e90fe60f49877c52f8 (patch)
treede67d641390772c696460bb9c493ef9c7e590d7e /addons/base_vat/models
parent72c29b105bdb4da5b306cd3b48a1683c1bf3e620 (diff)
[FIX] base_vat: Don't always pass VAT check when validating the VAT of a partner without country_id
Before this, when making a partner without any country_id, any VAT could be set to it, which was inconsistent with the module's purpose. closes odoo/odoo#68492 X-original-commit: 4c962437bd59a1e9302d8034e8870880994eb713 Related: odoo/enterprise#17358 Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com> Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
Diffstat (limited to 'addons/base_vat/models')
-rw-r--r--addons/base_vat/models/res_partner.py7
1 files changed, 3 insertions, 4 deletions
diff --git a/addons/base_vat/models/res_partner.py b/addons/base_vat/models/res_partner.py
index 2dcbee9d8cb..35ce8f0e4d8 100644
--- a/addons/base_vat/models/res_partner.py
+++ b/addons/base_vat/models/res_partner.py
@@ -159,10 +159,9 @@ class ResPartner(models.Model):
if not check_func(vat_country, vat_number):
#if fails, check with country code from country
country_code = partner.commercial_partner_id.country_id.code
- if country_code:
- if not check_func(country_code.lower(), partner.vat):
- msg = partner._construct_constraint_msg(country_code.lower())
- raise ValidationError(msg)
+ if not country_code or not check_func(country_code.lower(), partner.vat):
+ msg = partner._construct_constraint_msg(country_code.lower() if country_code else None)
+ raise ValidationError(msg)
def _construct_constraint_msg(self, country_code):
self.ensure_one()