diff options
| author | fw-bot <otis@odoo.com> | 2019-10-09 10:11:44 +0000 |
|---|---|---|
| committer | fw-bot <otis@odoo.com> | 2019-10-10 06:27:09 +0000 |
| commit | 91e4b00b8bf4587ffb41f3d48efeafb5ffd99dba (patch) | |
| tree | 0f9b55e029b274169b39fa4c79257d93a3292cad /addons/base_sparse_field/models/models.py | |
| parent | b0fc1cd4559d466f95f7146b67fde71974f0e7b8 (diff) | |
[FIX] base_sparse_field,mail: handle None _instanciate_attrs override
The parent was expected to return a dict, but it can also return None in some
cases. When that happens, the overrides were crashing because it is impossible
to assign a key/val to None.
Note that using `if` conditions like this also prevents from writing on the dict
if it is existing but empty, but due to the definition of the parent, if there
is a dict, it will not be empty.
closes odoo/odoo#38316
X-original-commit: 3525fad3b1729286d139b19a4a92f1821d94ad88
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Diffstat (limited to 'addons/base_sparse_field/models/models.py')
| -rw-r--r-- | addons/base_sparse_field/models/models.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/addons/base_sparse_field/models/models.py b/addons/base_sparse_field/models/models.py index c47d17eb5a5..cc886e808d8 100644 --- a/addons/base_sparse_field/models/models.py +++ b/addons/base_sparse_field/models/models.py @@ -57,7 +57,7 @@ class IrModelFields(models.Model): def _instanciate_attrs(self, field_data): attrs = super(IrModelFields, self)._instanciate_attrs(field_data) - if field_data.get('serialization_field_id'): + if attrs and field_data.get('serialization_field_id'): serialization_record = self.browse(field_data['serialization_field_id']) attrs['sparse'] = serialization_record.name return attrs |