[REF] various: convert res.config.settings to use ir.config_parameter integration

This commit updates the various res config of Odoo addons to use the
newly-introduced config_parameter field attribute.

1 files changed, 3 insertions, 13 deletions

diff --git a/addons/base_setup/models/res_config_settings.py b/addons/base_setup/models/res_config_settings.py
index e925bac6a05..2d8d43ffe0c 100644
--- a/addons/base_setup/models/res_config_settings.py
+++ b/addons/base_setup/models/res_config_settings.py
@@ -11,8 +11,8 @@ class ResConfigSettings(models.TransientModel):
     group_multi_company = fields.Boolean("Manage multiple companies", implied_group='base.group_multi_company')
     company_id = fields.Many2one('res.company', string='Company', required=True,
         default=lambda self: self.env.user.company_id)
-    default_user_rights = fields.Boolean("Default Access Rights")
-    default_external_email_server = fields.Boolean("External Email Servers")
+    default_user_rights = fields.Boolean("Default Access Rights", config_parameter='base_setup.default_user_rights')
+    default_external_email_server = fields.Boolean("External Email Servers", config_parameter='base_setup.default_external_email_server')
     module_base_import = fields.Boolean("Allow users to import data from CSV/XLS/XLSX/ODS files")
     module_google_calendar = fields.Boolean(
         string='Allow the users to synchronize their calendar  with Google Calendar')
@@ -28,7 +28,7 @@ class ResConfigSettings(models.TransientModel):
         help="Share your partners to all companies defined in your instance.\n"
              " * Checked : Partners are visible for every companies, even if a company is defined on the partner.\n"
              " * Unchecked : Each company can see only its partner (partners where company is defined). Partners not related to a company are visible for all companies.")
-    default_custom_report_footer = fields.Boolean("Default Custom Report Footer")
+    default_custom_report_footer = fields.Boolean("Default Custom Report Footer", config_parameter='base_setup.default_custom_report_footer')
     report_footer = fields.Text(related="company_id.report_footer", string='Custom Report Footer', help="Footer text displayed at the bottom of all reports.")
     group_multi_currency = fields.Boolean(string='Multi-Currencies',
             implied_group='base.group_multi_currency',
@@ -39,14 +39,7 @@ class ResConfigSettings(models.TransientModel):
     @api.model
     def get_values(self):
         res = super(ResConfigSettings, self).get_values()
-        params = self.env['ir.config_parameter'].sudo()
-        default_external_email_server = params.get_param('base_setup.default_external_email_server', default=False)
-        default_user_rights = params.get_param('base_setup.default_user_rights', default=False)
-        default_custom_report_footer = params.get_param('base_setup.default_custom_report_footer', default=False)
         res.update(
-            default_external_email_server=default_external_email_server,
-            default_user_rights=default_user_rights,
-            default_custom_report_footer=default_custom_report_footer,
             company_share_partner=not self.env.ref('base.res_partner_rule').active,
         )
         return res
@@ -54,9 +47,6 @@ class ResConfigSettings(models.TransientModel):
     @api.multi
     def set_values(self):
         super(ResConfigSettings, self).set_values()
-        self.env['ir.config_parameter'].sudo().set_param("base_setup.default_external_email_server", self.default_external_email_server)
-        self.env['ir.config_parameter'].sudo().set_param("base_setup.default_user_rights", self.default_user_rights)
-        self.env['ir.config_parameter'].sudo().set_param("base_setup.default_custom_report_footer", self.default_custom_report_footer)
         self.env.ref('base.res_partner_rule').write({'active': not self.company_share_partner})
 
     @api.multi