[IMP] Improved the separator name, sequence of buttons with icon, file name, used proper variable name and removed unnecessary for loop for base_module_quality module

bzr revid: bde@tinyerp.com-20110907085056-pte4mgqa4uuy5pol

4 files changed, 16 insertions, 28 deletions

diff --git a/addons/base_module_quality/__openerp__.py b/addons/base_module_quality/__openerp__.py
index 855084f3a7d..5459f14cb72 100644
--- a/addons/base_module_quality/__openerp__.py
+++ b/addons/base_module_quality/__openerp__.py
@@ -42,7 +42,7 @@ using it, otherwise it may crash.
     'website': 'http://www.openerp.com',
     'depends': ['base'],
     'init_xml': [],
-    'update_xml': ['wizard/module_quality_check.xml', 'wizard/quality_save_report_view.xml', 'base_module_quality_view.xml', 'security/ir.model.access.csv'],
+    'update_xml': ['wizard/module_quality_check_view.xml', 'wizard/quality_save_report_view.xml', 'base_module_quality_view.xml', 'security/ir.model.access.csv'],
     'demo_xml': [],
     'installable': True,
     'active': False,
diff --git a/addons/base_module_quality/wizard/module_quality_check.py b/addons/base_module_quality/wizard/module_quality_check.py
index 3e9247416b2..5693f0a0da1 100644
--- a/addons/base_module_quality/wizard/module_quality_check.py
+++ b/addons/base_module_quality/wizard/module_quality_check.py
@@ -28,32 +28,20 @@ from osv import osv, fields
 
 class quality_check(osv.osv_memory):
     _name = "quality.check"
+    _description = "Quality Check"
 
-    def create_quality_check(self, cr, uid, ids, context=None):
-        pool = pooler.get_pool(cr.dbname)
-        obj_quality = pool.get('module.quality.check')
-        objs = []
+    def _create_quality_check(self, cr, uid, ids, context=None):
+        obj_quality = self.pool.get('module.quality.check')
+        objs_ids = []
         module_id = context.get('active_id', False)
-        for id in ids:
-            module_data = pool.get('ir.module.module').browse(cr, uid, module_id)
-            data = obj_quality.check_quality(cr, uid, module_data.name, module_data.state)
-            obj = obj_quality.create(cr, uid, data, context)
-            objs.append(obj)
-        return objs
+        module_data = self.pool.get('ir.module.module').browse(cr, uid, module_id)
+        data = obj_quality.check_quality(cr, uid, module_data.name, module_data.state)
+        obj = obj_quality.create(cr, uid, data, context)
+        objs_ids.append(obj)
+        return objs_ids
 
-    def _create_quality_check(self, cr, uid, data, context=None):
-        pool = pooler.get_pool(cr.dbname)
-        obj_quality = pool.get('module.quality.check')
-        objs = []
-        for id in data['ids']:
-            module_data = pool.get('ir.module.module').browse(cr, uid, id)
-            data = obj_quality.check_quality(cr, uid, module_data.name, module_data.state)
-            obj = obj_quality.create(cr, uid, data, context)
-            objs.append(obj)
-        return objs
-
-    def open_quality_check(self, cr, uid, data, context):
-        obj_ids = self.create_quality_check(cr, uid, data, context)
+    def open_quality_check(self, cr, uid, ids, context):
+        obj_ids = self._create_quality_check(cr, uid, ids, context)
         return {
             'domain': "[('id','in', ["+','.join(map(str,obj_ids))+"])]",
             'name': _('Quality Check'),
@@ -64,4 +52,4 @@ class quality_check(osv.osv_memory):
             }
 quality_check()
 
-# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
\ No newline at end of file
diff --git a/addons/base_module_quality/wizard/module_quality_check.xml b/addons/base_module_quality/wizard/module_quality_check.xml
index 9eef017ebcb..07606dccac0 100644
--- a/addons/base_module_quality/wizard/module_quality_check.xml
+++ b/addons/base_module_quality/wizard/module_quality_check.xml
@@ -9,11 +9,10 @@
             <field name="arch" type="xml">
                 <form string="Quality Check">
                     <group colspan="4">
-                        <label string = "Check Quality" help="You can check the quality of selected module"/>
-                        <separator colspan="4"/>
+                        <separator string = "This wizard will check Module quality" colspan="4"/>
                         <newline/>
-                        <button name="open_quality_check" icon="gtk-ok" string="Check" type="object"/>
                         <button icon="gtk-cancel" string="Cancel" special="cancel"/>
+                        <button name="open_quality_check" icon="terp-camera_test" string="Check" type="object"/>
                     </group>
                 </form>
             </field>
diff --git a/addons/base_module_quality/wizard/quality_save_report.py b/addons/base_module_quality/wizard/quality_save_report.py
index fd4b03d4446..bc8edd2e992 100644
--- a/addons/base_module_quality/wizard/quality_save_report.py
+++ b/addons/base_module_quality/wizard/quality_save_report.py
@@ -31,6 +31,7 @@ from osv import osv, fields
 class save_report(osv.osv_memory):
 
     _name = "save.report"
+    _description = "Save Report"
 
     def default_get(self, cr, uid, fields, context=None):
         res = super(save_report, self).default_get(cr, uid, fields, context=context)