diff options
| author | rde <rde@odoo.com> | 2017-09-25 15:54:15 +0200 |
|---|---|---|
| committer | rde <rde@odoo.com> | 2017-09-26 16:08:14 +0200 |
| commit | 8baabfb6be9e1db1af0828d705d07a1ec6f0029a (patch) | |
| tree | 15cb01bcd2d445b48d0d0f05aeeff42b422b2599 /addons/base_import_module/tests | |
| parent | 0426849de18b587bd0624d644b1208a24edefde9 (diff) | |
[FIX] website_*: convert old ir.ui.view page=True into website.page in 1 record
Before this commit, website.page xml record were created in 2 steps:
1. Create an ir.ui.view record with <template> tag
2. Create a website.page record with <record model="website.page">
But this is useless since website.page inheritS ir.ui.view, you can create both
records just in one <record> tag.
Note: This is NOT TRUE in every case:
Odoo's ORM will suffix external_id of inherited records (in this case the
ir.ui.view created through the website.page record) with its model's name.
This can be a problem in some case (this is an example):
website_crm_template.xml create an ir.ui.view inheriting the
ir.ui.view 'website.contactus'.
But if we didn't keep website.page & ir.ui.view records split for that
specific case, the ir.ui.view would inherit a website.page record
causing an error. (website.contactus would be the id of the page record
while the ir.ui.view's id would be website.contactus_ir_ui_view)
In short: when migrating an ir.ui.view (<record> xml) to a website.page:
* If there is record inheriting the ir.ui.view ID, then split
website.page & ir.ui.view
* if not, you can create the website.page and its ir.ui.view both in one
record (<record model="website.page").
This commit also removed remaining page="True" from xml template since we
removed the 'page' attribute from ir.ui.view model overrided in website module.
Diffstat (limited to 'addons/base_import_module/tests')
| -rw-r--r-- | addons/base_import_module/tests/test_module/test.xml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/addons/base_import_module/tests/test_module/test.xml b/addons/base_import_module/tests/test_module/test.xml index 80e24a4293b..9722d9478d1 100644 --- a/addons/base_import_module/tests/test_module/test.xml +++ b/addons/base_import_module/tests/test_module/test.xml @@ -11,7 +11,7 @@ <field name="currency_id" ref="base.EUR"/> </record> - <template id="test_page" name="Test Page" page="True"> + <template id="test_page" name="Test Page"> <t t-call="website.layout"> <h1> This page comes from an imported module! |