diff options
| author | Romain Derie <rde@odoo.com> | 2018-11-26 16:52:40 +0000 |
|---|---|---|
| committer | Romain Derie <rde@odoo.com> | 2018-11-26 16:52:40 +0000 |
| commit | 52c38367801e9378812f8709f1f5d6ba5ef107ac (patch) | |
| tree | 90524c77d28bd02cc8bc2d2a8e8debb928b03858 /addons/base_import_module/tests/test_module/static/src | |
| parent | 30791b59b3996f69a80fbfd6c8ce7ee28e77aa03 (diff) | |
[IMP] website_sale(_comparison): simplify xpath for old customize_show
Historically, the `website_sale.product_attributes` was a customize option.
That template became a normal view (removed customize_show attribute) with
bbd2d0e42
As it is now a normal view, there is no reason left to be an xpath view and we
can move itw code directly into the inherited template.
That way, we can simplify the `website_sale_comparison.product_attributes_body`
template that was doing a cross xpath (inheriting `website_sale.product` but
xpathing a DOM element from `website_sale.product_attributes` which was also
inheriting `website_sale.product`).
Note that cross xpath was not working well with multi website but was fixed
with 410c07283b
Still, we should avoid doing cross xpath when possible (originally it was not
possible since the view was a customize_show) as it is hard to grep DOM element
to find possible breaking xpath when doing changes on DOM.
This is the reason of this commit.
closes odoo/odoo#29044
Diffstat (limited to 'addons/base_import_module/tests/test_module/static/src')
0 files changed, 0 insertions, 0 deletions
