diff options
| author | Robot Odoo <xmo+roboto@odoo.com> | 2019-02-13 14:16:25 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-02-13 14:16:25 +0100 |
| commit | 2d3dbff9653ed2b2a35e997f5c1faa99007085c5 (patch) | |
| tree | 0ce58a74fde6024cd654ab04390775eaf93e9bf7 /addons/base_import/static/src/xml/base_import.xml | |
| parent | 984bf2492a16f0ff357b3fc03712c68f1a011f96 (diff) | |
| parent | 7abeaf56b3ae544dbe24c4a9fe4fa6d919582aba (diff) | |
[IMP] web, *: remove explicit references to `session_id`
Before this rev. the `session_id` was provided by the server to the webclient (in
session_info, mostly) and was stored and accessible. This made XSS injection more
dangerous than they should be as it was very easy to steal the `session_id`.
As the browser automatically set the `session_id` on every request to the server,
the webclient shouldn't need any explicit reference.
Since rev. odoo/odoo@f4d541e the `session_id` cookie uses the `httponly` flag so
it cannot be accessed through client side script.
Task 1905359
closes odoo/odoo#30098
Diffstat (limited to 'addons/base_import/static/src/xml/base_import.xml')
| -rw-r--r-- | addons/base_import/static/src/xml/base_import.xml | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/addons/base_import/static/src/xml/base_import.xml b/addons/base_import/static/src/xml/base_import.xml index 951002b279f..c475a30036d 100644 --- a/addons/base_import/static/src/xml/base_import.xml +++ b/addons/base_import/static/src/xml/base_import.xml @@ -3,8 +3,6 @@ <t t-set="_id" t-value="_.uniqueId('export')"/> <form action="" method="post" enctype="multipart/form-data" class="oe_import"> <input type="hidden" name="csrf_token" t-att-value="csrf_token"/> - <input type="hidden" name="session_id" - t-att-value="widget.session.session_id"/> <input type="hidden" name="import_id"/> <div class="oe_import_box col-lg-12 d-none"> <input accept=".csv, .xls, .xlsx, .xlsm, .ods" t-attf-id="file_#{_id}" |